Bug 1031686 - oo-diagnostics should call oo-admin-yum-validator
Summary: oo-diagnostics should call oo-admin-yum-validator
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-18 14:41 UTC by Brenton Leanhardt
Modified: 2017-03-08 17:35 UTC (History)
4 users (show)

Fixed In Version: rubygem-openshift-origin-common-1.17.2.1-2.el6op
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-17 16:20:37 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Brenton Leanhardt 2013-11-18 14:41:29 UTC
Description of problem:

Now that we're planning to ship oo-admin-yum-validator via RPM it would be useful to have oo-diagnostics call it.  I do not think we should automatically fix anything but install use the --report-all flag.

Comment 5 Luke Meyer 2013-11-19 23:34:06 UTC
origin-server: https://github.com/openshift/origin-server/pull/4203

enterprise-server:
commit d45576b972fd5ef2cc704db84f65f4191ca57261
Author: Luke Meyer <lmeyer>
Date:   Tue Nov 19 18:26:47 2013 -0500

    <oo-diagnostics> validate yum conf if possible - bug 1031686


NOTE: this test will fail miserably under OSE 2.0 beta until we can actually ship in the 2.0 GA channels, because the beta channels are different.

Comment 6 openshift-github-bot 2013-11-20 00:55:56 UTC
Commits pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/d7c930be14d2c11df5072e439dbc7029b2d9cf61
<oo-diagnostics> test for clashing app frontends, bug 1031686

https://github.com/openshift/origin-server/commit/6379455911c5592548adeeb68e524ff13db62f42
<oo-diagnostics> validate yum conf if possible - bug 1031686

Comment 9 Ma xiaoqiang 2013-11-25 10:00:25 UTC
check on puddle[2.0/2013-11-22.1]
#oo-diagnostics test_yum_configuration 
WARN: test_yum_configuration
        oo-admin-yum-validator reported some possible problems
        with your package source configuration:
--------------------------------------------------------------
      No roles have been specified. Attempting to guess the roles for this system...
If the roles listed below are incorrect or incomplete, please re-run this script with the appropriate --role arguments
    broker
    client
Detected OpenShift Enterprise repository subscription managed by Red Hat Subscription Manager.
Could not determine product version. Please re-run this script with the --oo-version argument.
Please re-run this tool after making any recommended repairs to this system

--------------------------------------------------------------
        Incorrect package source configuration could lead to
        failure to install the correct RPMs.

1 WARNINGS
NO ERRORS

Now it can call oo-admin-yum-validator, but it can't find the right version of openshift. it should run with the "-c beta2.ini" flag.

Comment 10 Luke Meyer 2013-11-25 14:46:35 UTC
We can't ship it with -c beta.ini because once it ships... it will no longer be the beta. Because the beta channels are different from the GA channels, we effectively cannot test this until the GA channels are populated.

Ideally in the future yum-validator would be able to detect the OSE version is beta and use that. Right now it can't.

Not sure what state to leave this bug in. Would like to test it as soon as GA channels have content.

Comment 11 Ma xiaoqiang 2013-12-16 01:43:28 UTC
check it on puddle[2.0/2013-12-09.3] and rhn-2.0
# oo-diagnostics 
<--snip-->
WARN: test_yum_configuration
        oo-admin-yum-validator reported some possible problems
        with your package source configuration:
--------------------------------------------------------------
      No roles have been specified. Attempting to guess the roles for this system...
If the roles listed below are incorrect or incomplete, please re-run this script with the appropriate --role arguments
    node
    node-eap
Detected OpenShift Enterprise repository subscription managed by RHN Classic or RHN Satellite.
Detected installed OpenShift Enterprise version 2.0

The required OpenShift Enterprise repositories are missing:
    rhel-x86_64-server-6-ose-2.0-jbosseap
    jbappplatform-6-x86_64-server-6-rpm
Please verify that an OpenShift Enterprise subscription is attached to this system using either RHN Classic or Red Hat Subscription Manager by following the instructions here: https://access.redhat.com/site/articles/522923
Checking if yum-plugin-priorities is installed
Checking channel/repository priorities
Please re-run this tool after making any recommended repairs to this system
<--snip-->

Now oo-diagnostics have called oo-admin-yum-validator to check the resource.


Note You need to log in before you can comment on or make changes to this bug.