Red Hat Bugzilla – Bug 1031738
libqmi: harden application-level encoders and decoders
Last modified: 2015-03-05 08:31:33 EST
When reading strings, the generated *_validate functions do not check if the buffer has space for the length field. It seems that this can lead to an assert when decoding a message.
The generated function __qmi_message_dms_set_firmware_preference_request_create() calls qmi_utils_write_string_to_buffer() in a loop. It is not immediately obvious why the statically allocated target buffer has sufficient storage space for all those strings. In other cases, only a single PASCAL string is written to a buffer which has slightly less than 1024 bytes, which should be okay.
I don't know where the data comes from and if an untrusted source might trigger crashes this way, hence the private bug.
http://cgit.freedesktop.org/libqmi/commit/?id=451d627530686833fd5fffba9d412dfa9fe41fc5 qmi-codegen: make sure expected len is 4 bytes
http://cgit.freedesktop.org/libqmi/commit/?id=150768f6bba84182e7d3a956c36d5a7d27129759 qmi-codegen: error out if invalid array size element in JSON
http://cgit.freedesktop.org/libqmi/commit/?id=b439d6d13ec8a8e4ff247b7d042424f10574aa84 qmi-codegen: avoid buffer overlow in emit_input_tlv_add()
http://cgit.freedesktop.org/libqmi/commit/?id=c744b04814098ea3647de8d618bd88e5554e1a26 libqmi,utils: assert input buffer size when writing strings to buffer
http://cgit.freedesktop.org/libqmi/commit/?id=471d038fe38f7b99383f9654dcc8f6662d96e6f8 qmi-codegen: ensure enough buffer available to read string/array size variable
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.