Bug 1032573 - libbsd: fgetln, fgetwln implementations are broken
Summary: libbsd: fgetln, fgetwln implementations are broken
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libbsd
Version: 7.0
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: 7.0
Assignee: Lukáš Tinkl
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks: 1032518
TreeView+ depends on / blocked
 
Reported: 2013-11-20 12:21 UTC by Florian Weimer
Modified: 2015-07-13 17:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1162571 (view as bug list)
Environment:
Last Closed: 2014-01-23 15:06:20 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Florian Weimer 2013-11-20 12:21:11 UTC 
The implementation is broken because it is not thread-safe and does not really follow the behavior of the BSD function (the returned string could be destroyed by independent read operations on other streams).

I couldn't find any external users of these functions (as defined in libbsd), so it's probably safer to remove these functions.

fparseln could be implemented directly on top of getline because it does not return the pointer obtained from fgetln.
Note You need to log in before you can comment on or make changes to this bug.