Bug 1033350 - mech DSO should use `strerror_r`
Summary: mech DSO should use `strerror_r`
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: gssproxy
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Guenther Deschner
QA Contact: JianHong Yin
URL:
Whiteboard:
Depends On:
Blocks: 1032680
TreeView+ depends on / blocked
 
Reported: 2013-11-21 22:42 UTC by Dmitri Pal
Modified: 2014-06-18 05:23 UTC (History)
5 users (show)

Fixed In Version: gssproxy-0.3.0-4.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-16 08:19:50 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Dmitri Pal 2013-11-21 22:42:24 UTC
This bug is created as a clone of upstream ticket:
https://fedorahosted.org/gss-proxy/ticket/111

It currently uses `strerror` to construct error messages, which is not thread-safe.

Comment 1 Guenther Deschner 2013-11-27 17:38:07 UTC
Fix pushed, package built.

Comment 3 JianHong Yin 2013-12-19 02:41:14 UTC
review the code, and SanityOnly

[root@dhcp12-241 gssproxy-0.3.0]# grep strerror_r -r .
./src/gp_util.c:/* NOTE: because strerror_r() is such a mess with glibc, we need to do some
./src/gp_util.c:const char gp_internal_err[] = "Internal strerror_r() error.";
./src/gp_util.c:    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
./src/gp_util.c:    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
[root@dhcp12-241 gssproxy-0.3.0]# grep strerror_r -r ../../SOURCES/
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:strerror_r() which is a can of worms as 2 incompatible implementations
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+/* NOTE: because strerror_r() is such a mess with glibc, we need to do some
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+const char gp_internal_err[] = "Internal strerror_r() error.";
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);

https://beaker.engineering.redhat.com/jobs/563445
https://beaker.engineering.redhat.com/jobs/563446

Comment 4 Ludek Smid 2014-06-16 08:19:50 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.