Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1033350

Summary: mech DSO should use `strerror_r`
Product: Red Hat Enterprise Linux 7 Reporter: Dmitri Pal <dpal>
Component: gssproxyAssignee: Guenther Deschner <gdeschner>
Status: CLOSED CURRENTRELEASE QA Contact: JianHong Yin <jiyin>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: eguan, fweimer, gdeschner, qcai, ssorce
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gssproxy-0.3.0-4.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-16 08:19:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1032680    

Description Dmitri Pal 2013-11-21 22:42:24 UTC
This bug is created as a clone of upstream ticket:
https://fedorahosted.org/gss-proxy/ticket/111

It currently uses `strerror` to construct error messages, which is not thread-safe.

Comment 1 Guenther Deschner 2013-11-27 17:38:07 UTC
Fix pushed, package built.

Comment 3 JianHong Yin 2013-12-19 02:41:14 UTC
review the code, and SanityOnly

[root@dhcp12-241 gssproxy-0.3.0]# grep strerror_r -r .
./src/gp_util.c:/* NOTE: because strerror_r() is such a mess with glibc, we need to do some
./src/gp_util.c:const char gp_internal_err[] = "Internal strerror_r() error.";
./src/gp_util.c:    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
./src/gp_util.c:    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
[root@dhcp12-241 gssproxy-0.3.0]# grep strerror_r -r ../../SOURCES/
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:strerror_r() which is a can of worms as 2 incompatible implementations
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+/* NOTE: because strerror_r() is such a mess with glibc, we need to do some
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+const char gp_internal_err[] = "Internal strerror_r() error.";
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);
../../SOURCES/gssproxy-0.3.1-strerror_r.patch:+    ret = strerror_r(errnum, buf, MAX_GP_STRERROR);

https://beaker.engineering.redhat.com/jobs/563445
https://beaker.engineering.redhat.com/jobs/563446

Comment 4 Ludek Smid 2014-06-16 08:19:50 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.