Description of problem: Obsolete projects should not be displayed in a group's projects lists or be counted towards the stats of the group Version-Release number of selected component (if applicable): dev How reproducible: Easy, always Steps to Reproduce: Preconditions: - Two projects exist - both with a source document - One of the projects is obsolete 1. Sign in, go to groups, select a group 2. Add the ACTIVE project to the group (Go to Settings -> Projects, Add) - Note the values for translated/total hours have increased 3. Add the OBSOLETE project to the group Actual results: The numbers have increased to accomodate the obsolete project Expected results: The numbers should only refer to the active projects Additional info: Also occurs if an group added project is made obsolete while part of a group
Pull request: https://github.com/zanata/zanata-server/pull/290
The fix also removes READONLY projects, which I believe is not favourable.
Pull request: https://github.com/zanata/zanata-server/pull/293
Created attachment 828496 [details] Screenshot of error Also, the number of warnings against a language still recognises obsolete projects. i.e. if two active projects and one obsolete project are part of a group and all have disabled a language, only two of those should show as warnings. Only two items show in the list, but the number shows three.
The READONLY project successfully showed in the group, once - but caused an exception after that when clicked. Now again it won't show at all.
Never mind about the "won't show at all" - I didn't realise that the set OBSOLETE on a project filters down through its versions, thus is not reverted when the project is made ACTIVE. i.e. I had to make the project version ACTIVE also. Exception still there. 1. Make a project version in the group READONLY 2. Click on the Languages tab 3. Click on a Language
Pull request: https://github.com/zanata/zanata-server/pull/296
This appears to behave better. Verified at 19c23e1a933e97cb309638a92053d139f26fedd0