Bug 1033553 - Remove EmsAttibute.valueHistory
Summary: Remove EmsAttibute.valueHistory
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Performance, Plugins
Version: 4.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHQ 4.11
Assignee: Heiko W. Rupp
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: JON3-2
TreeView+ depends on / blocked
 
Reported: 2013-11-22 11:28 UTC by Heiko W. Rupp
Modified: 2014-07-21 10:14 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-07-21 10:14:02 UTC
Embargoed:


Attachments (Terms of Use)
Diff to illustrate the change (6.28 KB, patch)
2013-12-13 14:08 UTC, Heiko W. Rupp
no flags Details | Diff

Description Heiko W. Rupp 2013-11-22 11:28:19 UTC
EmsAttribute's implementation DAttribute has an attribute valueHistory,
that is implemented with a class that always allocates a LinkedList with a default size.
We don't use that history in RHQ and it looks like the contents are never updated inside Ems anyway

We should probably remove that - as in larger setups with many JMX servers with many MBeans, those valueHistory objects can pile up a large set of unused memory.

Comment 1 Heiko W. Rupp 2013-12-13 14:08:32 UTC
Created attachment 836338 [details]
Diff to illustrate the change

Comment 2 John Mazzitelli 2013-12-13 14:12:39 UTC
Before we remove something like this from a third party library which we don't own, we'll need to talk to that project's community and owner. That attribute could be used for other things (I know MC4J uses EMS as well, it perhaps is using this attribute?)

Comment 3 Heiko W. Rupp 2013-12-30 12:24:35 UTC
I have forked ems into https://github.com/rhq-project/ems and applied the patch,
as well as a patch to DMBean that lazily allocates the collections for attributes, operations and notifications and also removes a redundant collection of operations.

Comment 4 Heiko W. Rupp 2014-03-05 14:11:06 UTC
A "standard" maven build seems not enough, as ems does some magic like including the -impl jar inside the jar and also including some strange mx4j libs, where it is not
clear how/if they are used at all.

Running "ant install" will build the "correct" jar though.

Comment 5 Heiko W. Rupp 2014-03-05 14:11:06 UTC
A "standard" maven build seems not enough, as ems does some magic like including the -impl jar inside the jar and also including some strange mx4j libs, where it is not
clear how/if they are used at all.

Running "ant install" will build the "correct" jar though.

Comment 6 Heiko W. Rupp 2014-04-09 15:49:06 UTC
New ems version is now in https://github.com/rhq-project/ems

Pushed a pull-request at https://github.com/rhq-project/rhq/pull/20

Comment 7 Heiko W. Rupp 2014-04-14 20:52:15 UTC
This was merged as 5e16dabce29a28d5ac7704483711865dd02e1f85 into master

Comment 8 Heiko W. Rupp 2014-07-21 10:14:02 UTC
Bulk closing of RHQ 4.11 issues, now that RHQ 4.12 is out.

If you find an issue with those, please open a new BZ, linking to the old one.


Note You need to log in before you can comment on or make changes to this bug.