RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1033696 - loader.Loader.load_modules doesn't call Loader._needs_network correctly
Summary: loader.Loader.load_modules doesn't call Loader._needs_network correctly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: firstboot
Version: 7.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: rc
: ---
Assignee: Vratislav Podzimek
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks: 860099 rhsm-rhel70 1025386
TreeView+ depends on / blocked
 
Reported: 2013-11-22 16:15 UTC by Adrian Likins
Modified: 2014-06-18 07:41 UTC (History)
7 users (show)

Fixed In Version: firstboot-19.5-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 12:35:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
fix missing Loader._needs_network call (805 bytes, patch)
2013-11-22 16:18 UTC, Adrian Likins
no flags Details | Diff

Description Adrian Likins 2013-11-22 16:15:17 UTC
Description of problem:
diff --git i/firstboot/loader.py w/firstboot/loader.py
index 2f65fbc..6373e32 100644
--- i/firstboot/loader.py
+++ w/firstboot/loader.py
@@ -84,7 +84,7 @@ class Loader:
                 continue

             # skip modules that require network if it's not active
-            if not self._has_network and modobj.needsNetwork():
+            if not self._has_network() and modobj.needsNetwork():
                 log.error('module requires active network connection')
                 continue


Loader doesn't call self._has_network, but just accidentally checks that it doesn't exists and ignores needsNetwork().

Module that do need network are not skipped if there is no networking.

Comment 2 Adrian Likins 2013-11-22 16:18:33 UTC
Created attachment 827881 [details]
fix missing Loader._needs_network call

Patch against master.

Comment 5 Jan Stodola 2014-01-13 11:14:14 UTC
Reproduced with firstboot-19.4-2.el7 - Subscription Management Registration (SMR) started although no network interface was running.
With firstboot-19.5-2.el7, SMR was started only when network interface was up and running.

Moving to VERIFIED.

Comment 6 Ludek Smid 2014-06-13 12:35:33 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.