Bug 1033902 - FTBFS on big endians
Summary: FTBFS on big endians
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xfsprogs
Version: rawhide
Hardware: s390x
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2013-11-24 09:12 UTC by Dan Horák
Modified: 2013-11-25 23:18 UTC (History)
1 user (show)

Fixed In Version: xfsprogs-3.2.0-0.2.alpha2
Clone Of:
Environment:
Last Closed: 2013-11-25 23:18:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dan Horák 2013-11-24 09:12:22 UTC
xfsprogs-3.2.0-0.1.alpha1.fc21 fails to build on big endian arches (s390, ppc), please sync with RHEL-7 package. For full logs see for example http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1269837 and http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1542535


Version-Release number of selected component (if applicable):
xfsprogs-3.2.0-0.1.alpha1.fc21

Comment 1 Eric Sandeen 2013-11-25 16:29:29 UTC
> crc32c: 100 self tests failed

It'll be fixed shortly in -alpha2:

commit b2dbd6a9a2df5099882bdfc068caa76cf334c99a
Author: Eric Sandeen <sandeen>
Date:   Sat Oct 5 02:20:03 2013 +0000

    xfsprogs: fix crc32 build on big endian
    
    While kernelspace can test #ifdef __LITTLE_ENDIAN, this
    doesn't work in userspace.  __LITTLE_ENDIAN is defined -
    as is __BIG_ENDIAN.
    
    So we build on all boxes as __LITTLE_ENDIAN, and the
    self-test (thankfully!) fails on big endian boxes.
    
    Fix this by testing __BYTE_ORDER values.
    
    And add an else which should never be hit, but just in case...
    
    Signed-off-by: Eric Sandeen <sandeen>
    Reviewed-by: Dave Chinner <dchinner>
    Signed-off-by: Rich Johnston <rjohnston>

Comment 2 Eric Sandeen 2013-11-25 23:18:08 UTC
Should be good in Rawhide, please reopen if not.

Thanks!

-Eric


Note You need to log in before you can comment on or make changes to this bug.