Bug 1033987 - Review Request: perl-Lingua-EN-Fathom - Measure readability of English text
Summary: Review Request: perl-Lingua-EN-Fathom - Measure readability of English text
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1033986
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-25 00:58 UTC by Ruediger Landmann
Modified: 2014-04-24 05:54 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-24 05:54:30 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ruediger Landmann 2013-11-25 00:58:39 UTC
Spec URL: http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Fathom.spec
SRPM URL: http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Fathom-1.15-1.fc19.src.rpm
Description: This module analyses English text in either a string or file. Totals are then calculated for the number of characters, words, sentences, blank and non blank (text) lines and paragraphs.
Fedora Account System Username: rlandmann

rpmlint output:

$ rpmlint SPECS/perl-Lingua-EN-Fathom.spec SRPMS/perl-Lingua-EN-Fathom-1.15-1.fc19.src.rpm RPMS/noarch/perl-Lingua-EN-Fathom-1.15-1.fc19.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Parag AN(पराग) 2013-11-28 15:36:05 UTC
The whiteboard says this package is not ready but I have tested this package in mock.

+ package builds in rawhide mock

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as (sha1256sum)
srpm tarball  ff90d74714d3fc04b928b1d467cfbe206d89cfce4a466b065311d98e03849897
upstream tarball  ff90d74714d3fc04b928b1d467cfbe206d89cfce4a466b065311d98e03849897

+ make check gave
All tests successful.
Files=3, Tests=15,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.12 cusr  0.01 csys =  0.15 CPU)


+ Package  perl-Lingua-EN-Fathom-1.15-1.fc21.noarch
Provides: perl(Lingua::EN::Fathom) = 1.15 perl-Lingua-EN-Fathom = 1.15-1.fc21
Requires: perl(Lingua::EN::Syllable) perl(strict) perl(warnings)


I suppose this package also need to be built in EPEL so spec looks ok.

suggestions
1) yum/rpm picks required perl dependencies automatically so this package don't need following in spec
Requires:       perl(Lingua::EN::Syllable)

2) you may want to remove line also
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;

Comment 2 Jeff Fearn 🐞 2014-01-08 04:34:16 UTC
Hi, Rudi is a bit busy so I've made the requested changes.

http://fedorapeople.org/~jfearn/files/perl-Lingua-EN-Fathom-1.15-2.fc19.src.rpm
http://fedorapeople.org/~jfearn/files/perl-Lingua-EN-Fathom.spec

Comment 3 Parag AN(पराग) 2014-01-09 09:49:49 UTC
The new srpm package looks good.

APPROVED.

Comment 4 Ruediger Landmann 2014-01-09 11:27:42 UTC
New Package SCM Request
=======================
Package Name: perl-Lingua-EN-Fathom
Short Description: Measure readability of English text
Owners: rlandmann jfearn
Branches: f18 f19 f20 el5 el6 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-01-09 14:09:57 UTC
Git done (by process-git-requests).

No new f18 branches are being created.

Comment 6 Ruediger Landmann 2014-01-09 23:57:29 UTC
Thanks Parag, Jeff, and Jon :)

Comment 7 Petr Pisar 2014-04-16 07:10:38 UTC
This package has not been committed and built for F21:

petr@dhcp-0-146:~/fedora/perl-Lingua-EN-Fathom $ git branch
* master
petr@dhcp-0-146:~/fedora/perl-Lingua-EN-Fathom $ git log
commit bd88cd7fe8256d6107b3e860839d86b90c0a8502
Author: Fedora Release Engineering <rel-eng.org>
Date:   Thu Jan 9 14:09:47 2014 +0000

    Initial setup of the repo


You have to build from master branch for the Rawhide Fedora.

Comment 8 Ruediger Landmann 2014-04-24 05:54:30 UTC
Fixed; thanks

http://koji.fedoraproject.org/koji/buildinfo?buildID=512752


Note You need to log in before you can comment on or make changes to this bug.