Spec URL: http://berrange.fedorapeople.org/review/libvirt-python/libvirt-python.spec SRPM URL: http://berrange.fedorapeople.org/review/libvirt-python/libvirt-python-1.2.0-0.rc0.fc19.src.rpm Description: This package provides the python binding for the libvirt library. It was previously distributed as a sub-RPM of the main libvirt package, but is now split into a dedicated RPM. There should be no functional change from the POV of an application using the libvirt python binding Fedora Account System Username: berrange
NB: rpmlint will report the Source0 URL as bogus. This is because upstream libvirt has not yet done the first release of the libvirt-python binding. This review is being opened pre-emptively, so we can get the review under way. We don't intend to actually add this to Fedora until upstream has formally released the libvirt-python library, and thus fixed the URL. Similarly the '0.rc0' part of the release tag would go away to be replaced by '1'
Some bits flagged by fedora-review: libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod_qemu.so libvirtmod_qemu.so()(64bit) libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod_lxc.so libvirtmod_lxc.so()(64bit) libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod.so libvirtmod.so()(64bit) The %filter macros handle this, it's just not the 'newest' way. So that's fine. libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt_lxc.py 0644L /usr/bin/python libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt_qemu.py 0644L /usr/bin/python libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt.py 0644L /usr/bin/python Indeed /usr/bin/python should be dropped from these files upstream, but not a blocker really. Manual review looks fine. There's some stuff that could be dropped if the spec was only targeting modern Fedora, but given how libvirt tracks specs upstream and still targets RHEL5 it makes sense why devs would want to keep those bits. So ACK. When the official release is done I'll re-review and set the correct flags.
Spec URL: http://berrange.fedorapeople.org/review/libvirt-python/libvirt-python.spec SRPM URL: http://berrange.fedorapeople.org/review/libvirt-python/libvirt-python-1.2.0-1.fc19.src.rpm The bogus provides should be gone in this SRPM - the previous SRPM was built with the wrong spec file which lacked the %filter rules.
Looks good. Please remember to add virt-maint.org to the CC list
New Package SCM Request ======================= Package Name: libvirt-python Short Description: The libvirt virtualization API python binding Owners: berrange crobinso veillard Branches: InitialCC: virt-maint.org
virt-maint.org is not a valid FAS account, please use the corresponding FAS account name.
New Package SCM Request ======================= Package Name: libvirt-python Short Description: The libvirt virtualization API python binding Owners: berrange crobinso veillard Branches: InitialCC: virtmaint
Complete, please add comaintainers in pkgdb.
@jon is the GIT repository actually created ? I'm unable to check it out $ git clone ssh://pkgs.fedoraproject.org/libvirt-python Cloning into 'libvirt-python'... fatal: '/srv/git/rpms//libvirt-python.git' does not appear to be a git repository fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Looking at GITWEB the repository does not exist http://pkgs.fedoraproject.org/cgit/libvirt-python.git/
Looks like something odd happened, try it now.
Seems to be fine now