Version-Release number of selected component: network-manager-applet-0.9.9.0-7.git20131028.fc21 Additional info: reporter: libreport-2.1.9 backtrace_rating: 4 cmdline: /bin/nm-applet crash_function: g_object_finalize executable: /usr/bin/nm-applet kernel: 3.12.0-1.fc21.i686 runlevel: N 5 type: CCpp uid: 0 Truncated backtrace: Thread no. 1 (6 frames) #2 g_object_finalize at gobject.c:1030 #4 constructor at applet.c:3727 #5 g_object_new_with_custom_constructor at gobject.c:1643 #6 g_object_new_internal at gobject.c:1720 #7 g_object_new_valist at gobject.c:1978 #9 nm_applet_new at applet.c:3851
Created attachment 828990 [details] File: backtrace
Created attachment 828991 [details] File: cgroup
Created attachment 828993 [details] File: core_backtrace
Created attachment 828994 [details] File: dso_list
Created attachment 828995 [details] File: environ
Created attachment 828996 [details] File: limits
Created attachment 828997 [details] File: maps
Created attachment 828998 [details] File: open_fds
Created attachment 828999 [details] File: proc_pid_status
Created attachment 829000 [details] File: var_log_messages
Created attachment 829301 [details] patch
(In reply to Dan Winship from comment #11) > Created attachment 829301 [details] > patch Patch looks good; also tested normal (works) and without info.ui (correctly fails with warning message and no glib spew).
The patch looks good, just fix indentation in #ifdef BUILD_MIGRATION_TOOL block.
(Looks good to me too) Just wondering, maybe the code in "#ifdef BUILD_MIGRATION_TOOL" should check if (g_file_test (argv[0], G_FILE_TEST_IS_EXECUTABLE)) { ... and only to spawn the process in that case? Also, isn't it a bit unthrifty to spawn the migration process at every start?
(In reply to Thomas Haller from comment #14) > (Looks good to me too) > > > > Just wondering, maybe the code in "#ifdef BUILD_MIGRATION_TOOL" should check > > if (g_file_test (argv[0], G_FILE_TEST_IS_EXECUTABLE)) { > ... > > and only to spawn the process in that case? Also, isn't it a bit unthrifty > to spawn the migration process at every start? Yeah, it is, but we don't want to link the main applet to GConf at all, and that would be required to do even a small check to see if migration happened. But also, we don't build the migration stuff in Fedora 20 or later, or in RHEL7. The last time Fedora shipped with NM 0.8.x, which would require the migration on upgrade, was Fedora 14 (May 2011), and anyone upgrading from F14 to F20 can just re-create their network settings...
committed upstream