Bug 103519 - 2.4.21-20.1.2024.2.1.nptl compile problems: lm87.c, dmi_scan.c wvlan_cs.c
Summary: 2.4.21-20.1.2024.2.1.nptl compile problems: lm87.c, dmi_scan.c wvlan_cs.c
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: kernel
Version: 1.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dave Jones
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-09-01 18:07 UTC by Marcel Mol
Modified: 2015-01-04 22:03 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-01-05 04:42:22 UTC
Embargoed:


Attachments (Terms of Use)
these simple patches fix it for my case. (1.62 KB, patch)
2003-09-01 18:10 UTC, Marcel Mol
no flags Details | Diff

Description Marcel Mol 2003-09-01 18:07:54 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703

Description of problem:
recompiling the kernel from the src rpm fails with errors in lm87.c, dmi_scan.c
and wvlan_cs.c compiled as module. After applying the attached small patch
things work fine again. This is using gcc-3.3.1-1.

Version-Release number of selected component (if applicable):
kernel-source-2.4.21-20.1.2024.2.1.nptl

How reproducible:
Always

Steps to Reproduce:
1. Using my .config (if needed I can attach it)
2. make clean depend bzImage modules
3. compiler errors result in the modules part
    

Actual Results:  gcc errors 

Expected Results:  no compile errors

Additional info:

For lm87.c:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.21-20.1.2024.2.1.nptl/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-st
rict-aliasing -fno-common -fomit-frame-pointer -pipe
-mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS -in
clude /usr/src/linux-2.4.21-20.1.2024.2.1.nptl/include/linux/modversions.h 
-nostdinc -iwithprefix include -DKBUILD_BASE
NAME=lm87  -c -o lm87.o lm87.c
lm87.c:1063:6: missing terminating " character
lm87.c:1066:60: missing terminating " character
lm87.c:1081:1: unterminated argument list invoking macro "MODULE_AUTHOR"
lm87.c:1081: error: syntax error at end of input
lm87.c:1024: warning: `sensors_lm87_init' defined but not used
make[2]: *** [lm87.o] Error 1


From dmi_scan.c (tis is from the previous kerniel, but 2.4.21-xxx
has the same error):

gcc -D__KERNEL__ -I/usr/src/linux-2.4.20-20.1.2013.nptl/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict
-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
-march=i686 -DMODULE -DMODVERSIONS -includ
e /usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/modversions.h  -nostdinc
-iwithprefix include -DKBUILD_BASENAME=dmi
_scan  -DEXPORT_SYMTAB -c dmi_scan.c
In file included from
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/sensors.h:24,
                 from dmi_scan.c:19:
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/i2c-proc.h:34: warning:
`struct i2c_client' declared inside parameter
 list
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/i2c-proc.h:34: warning: its
scope is only this definition or declarat
ion, which is probably not what you want
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/i2c-proc.h:77: warning:
`struct i2c_client' declared inside parameter
 list
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/i2c-proc.h:352: warning:
`struct i2c_adapter' declared inside paramet
er list
/usr/src/linux-2.4.20-20.1.2013.nptl/include/linux/i2c-proc.h:360: warning:
`struct i2c_adapter' declared inside parameter list


wvlan_cs.c has errors like lm87.c but I do not have the output handy
anymore.

Comment 1 Marcel Mol 2003-09-01 18:10:00 UTC
Created attachment 94120 [details]
these simple patches fix it for my case.

Just noticed this patch is a reverse patch. Please test/apply using the patch
-R option.

Comment 2 Marcel Mol 2003-09-14 09:03:49 UTC
Just tested with kernle-2.4.22-1.2040nptl and gcc 3.3.1-4.
This resolves the compile problems for lm87.c and wvlan_cs.c
but drivers/i2c/dmi_scan.c still needs the #include <linux/i2c.h>


Comment 3 Dave Jones 2004-01-05 04:42:22 UTC
building the FC1 kernel with gcc 3.3 is unsupported for more reasons
than just the obvious failures.



Note You need to log in before you can comment on or make changes to this bug.