Bug 1035751 - Brick processes crash when the test 'bug-887098-gmount-crash.t' is run after building glusterfs with DDEBUG flags
Summary: Brick processes crash when the test 'bug-887098-gmount-crash.t' is run after ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-28 11:43 UTC by Krutika Dhananjay
Modified: 2014-11-11 08:24 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:24:59 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2013-11-28 11:43:45 UTC
Description of problem:
Brick processes crash when the test 'bug-887098-gmount-crash.t' is run on glusterfs after building with DDEBUG flag.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Build glusterfs from source with -DDEBUG flag.
2. Run the test mentioned in the Bug Summary

Actual results:
The test fails midway, resulting from brick processes crashing.

Expected results:
The test must succeed with NO crashes.

Additional info:

This is caused due to a CALLOC'd object (created in posix-acl xlator which has no memory accounting), that is GF_FREE'd later as part of data_destroy().

Comment 1 Anand Avati 2013-11-28 12:01:18 UTC
REVIEW: http://review.gluster.org/6377 (posix-acl: Fix crash resulting from GF_FREE() done on a CALLOC'd object) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Krutika Dhananjay 2013-11-28 12:01:41 UTC
http://review.gluster.org/#/c/6377/

Comment 3 Anand Avati 2013-11-28 16:46:41 UTC
COMMIT: http://review.gluster.org/6377 committed in master by Vijay Bellur (vbellur) 
------
commit 72d3dde33bd12f4aea96d59097bef5df45672610
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Nov 28 16:47:09 2013 +0530

    posix-acl: Fix crash resulting from GF_FREE() done on a CALLOC'd object
    
    The object in question was created in posix_acl_inherit () and
    was being GF_FREE'd as part of data_destroy().
    
    Change-Id: Ibdb7c3b5c10ce447f061bde68452502e5170de92
    BUG: 1035751
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/6377
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2014-03-25 11:14:00 UTC
REVIEW: http://review.gluster.org/7332 (features/glupy: Add mem accounting support) posted (#1) for review on master by Prashanth Pai (ppai)

Comment 5 Anand Avati 2014-04-02 05:45:56 UTC
REVIEW: http://review.gluster.org/7332 (features/glupy: Add mem accounting support) posted (#2) for review on master by Prashanth Pai (ppai)

Comment 6 Anand Avati 2014-04-04 04:51:56 UTC
COMMIT: http://review.gluster.org/7332 committed in master by Vijay Bellur (vbellur) 
------
commit ca6af761fb63068b170b9e8b1143598af244e06c
Author: Prashanth Pai <ppai>
Date:   Tue Mar 25 16:15:15 2014 +0530

    features/glupy: Add mem accounting support
    
    When glusterfs is built from source using -DDEBUG flag and glupy
    xlator is added to vol file, the brick process used to crash when
    mounting the volume.
    
    This fix is largely derived from the fix submitted for BZ #1035751.
    Thanks to Justin Clift for helping in tracking this down.
    
    BUG: 1035751
    Change-Id: Id64f92eecc9335e34dd08812fe176774e7723c2c
    Signed-off-by: Prashanth Pai <ppai>
    Reviewed-on: http://review.gluster.org/7332
    Reviewed-by: Jeff Darcy <jdarcy>
    Tested-by: Gluster Build System <jenkins.com>

Comment 7 Anand Avati 2014-04-04 07:32:19 UTC
REVIEW: http://review.gluster.org/7397 (features/glupy: Add mem accounting support) posted (#1) for review on release-3.5 by Prashanth Pai (ppai)

Comment 8 Niels de Vos 2014-09-22 12:33:05 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 9 Niels de Vos 2014-11-11 08:24:59 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.