Bug 1035799 - f20 tc3, adding a new mount point, desired capacity empty, crash
Summary: f20 tc3, adding a new mount point, desired capacity empty, crash
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vratislav Podzimek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
: 1036025 1036250 (view as bug list)
Depends On:
Blocks: F20FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2013-11-28 13:53 UTC by Rui Matos
Modified: 2014-02-21 20:03 UTC (History)
11 users (show)

Fixed In Version: anaconda-20.25.14-1.fc20
Clone Of:
Environment:
Last Closed: 2013-12-10 06:54:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Rui Matos 2013-11-28 13:53:14 UTC
f20 tc3, adding a new mount point, left the desired capacity empty (I want to use the whole [virtual] disk). anaconda crashes with the following:

anaconda 20.25.11-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 157, in size_from_entry
    if unicodedata.category(size_text[-1]).startswith("L"):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 290, in on_add_confirm_clicked
    self.size = size_from_entry(self.builder.get_object("addSizeEntry"))
IndexError: string index out of range
 
Local variables in innermost frame:
entry: <Entry object at 0x7f47ac092c30 (GtkEntry at 0x45dbba0)>
size_text:
 
 
Anaconda instance, containing members:
_instClass: DefaultInstall instance, containing members:
_intf: GraphicalUserInterface instance, containing members:
  _intf.instclass: Already dumped (DefaultInstall instance)
  _intf._mehInterface: GraphicalExceptionHandlingIface instance, containing members:
    _intf._mehInterface._lightbox_func: <bound method GraphicalUserInterface.lightbox_over_current_action of <pyanaconda.ui.gui.GraphicalUserInterface object at 0x3951e10>>
  _intf._quitDialog: <class 'pyanaconda.ui.gui.QuitDialog'>
  _intf.data: #version=DEVEL

Comment 1 Kamil Páral 2013-11-28 14:31:38 UTC
This violates:
" Reject or disallow invalid disk and volume configurations without crashing. "
https://fedoraproject.org/wiki/Fedora_20_Beta_Release_Criteria#Guided_partitioning

Comment 2 Kamil Páral 2013-12-02 10:46:09 UTC
Reproduced.

In case I can't attend today's blocker bug meeting, I vote +1 blocker.

Comment 3 Vratislav Podzimek 2013-12-02 12:51:29 UTC
Reviewed one-liner fix ready for pushing:
https://lists.fedorahosted.org/pipermail/anaconda-patches/2013-November/007553.html

Comment 4 David Shea 2013-12-02 16:45:10 UTC
*** Bug 1036025 has been marked as a duplicate of this bug. ***

Comment 5 Adam Williamson 2013-12-02 17:40:21 UTC
Discussed at 2013-12-02 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-12-02/f20-blocker-review-%234.2013-12-02-17.02.log.txt . Accepted as a blocker per criterion ""The installer must be able to create and install to any workable partition layout... " - https://fedoraproject.org/wiki/Fedora_20_Final_Release_Criteria#Disk_layouts .

Comment 6 Fedora Update System 2013-12-03 00:34:08 UTC
anaconda-20.25.13-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.25.13-1.fc20

Comment 7 Adam Williamson 2013-12-03 01:13:00 UTC
Looks fixed to me in 20.25.13 in a smoke test image I just built.

Comment 8 Dan Mossor [danofsatx] 2013-12-04 18:48:13 UTC
Confirmed fixed in F20 TC4. Leaving size blank will use all available disk space for the partition size.

Comment 9 Fedora Update System 2013-12-05 01:12:59 UTC
anaconda-20.25.14-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.25.14-1.fc20

Comment 10 Fedora Update System 2013-12-10 06:54:12 UTC
anaconda-20.25.14-1.fc20, python-blivet-0.23.8-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 David Shea 2014-02-21 20:03:39 UTC
*** Bug 1036250 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.