Hide Forgot
Spec URL: http://fedorapeople.org/~brouhaha/faifa/faifa.spec SRPM URL: http://fedorapeople.org/~brouhaha/faifa/faifa-0.1-0.1.20131129git68cffbb.fc19.src.rpm Description: Faifa can configure Power Line Communication devices (e.g. HomePlug AV) using Qualcomm (formerly Intellon) chipsets. It supports all Intellon-specific management and control frames as well as standard management frames. Fedora Account System Username: brouhaha
The development symlink for libfaifa is missing from the devel package. Upstream should adjust its build system to install the library with executable permissions. hpav_cfg is under BSD license. Since it compiles into a single binary that is not linked to libfaifa, the package license should be "GPLv2+ and BSD". The license must be included in the libs package, rather than the main package here, as the libs package can be installed without the main package. The compiler warnings should be taken care of as well.
Thanks for looking at this. I'm not completely certain that I understand the "development symlink" comment. I reported upstream, but my explanation may not be accurate: https://github.com/ffainelli/faifa/issues/5 I reported the executable permissions issue and added a comment to the spec: https://github.com/ffainelli/faifa/issues/4 I moved the license and changed the License tag as you suggested. I believe fixing compiler warnings is out of scope for Fedora packaging. Updated to latest upstream git. Spec URL: http://fedorapeople.org/~brouhaha/faifa/faifa.spec SRPM URL: http://fedorapeople.org/~brouhaha/faifa/faifa-0.1-0.2.20140228git9f2dcd3.fc19.src.rpm
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.