Bug 1036635 - Unclear audit log message for corrupted ovf in export domain
Summary: Unclear audit log message for corrupted ovf in export domain
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Michal Skrivanek
QA Contact: Ilanit Stein
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-02 11:45 UTC by Ilanit Stein
Modified: 2016-04-20 01:11 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-20 01:11:49 UTC
oVirt Team: Virt
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 35102 0 master MERGED core: detailed error message on OVF import error Never

Description Ilanit Stein 2013-12-02 11:45:05 UTC
Description of problem:
	
Please change event message:
"Failed to read VM '[Empty Name]' OVF, it may be corrupted", to be more clear.
For example, by adding the ovf file name/s. 
This way user will be able to identify which ovfs are corrupted. 

Version-Release number of selected component (if applicable):
is25

How reproducible:
100%

Steps to Reproduce:
1. Have corrupted ovf vm/template in export domain
2. Go to export domain OR, 
   Refresh export domain OR,  
   Import / Export VM from/to export domain.

Comment 1 Michal Skrivanek 2014-08-22 13:01:26 UTC
this bug won't fit into 3.5 release and is being deferred to a later release. If you deeply care about this bug and deserves to be re-evaluated please let me know

Comment 2 Richard W.M. Jones 2014-09-16 22:27:49 UTC
Yes, please fix this bug.  It affects virt-v2v, and makes it
impossible for us to debug problems with the OVF we are generating.

Comment 3 Omer Frenkel 2014-10-29 15:13:22 UTC
Hi Richard, what exactly are you missing that can make debugging easier?
the message this bug talks about is the message in the ui event log, you always have the detailed info in the engine.log

also, the ovf file name is not reported to the engine, only the content, as a string, so if its corrupted and we couldn't extract the name, we might not be able to get anything from it (it can also be a garbage string, nothing to show the user)

if we really think that in this case the name of the file would be helpful, a bigger change would be required.

i'm not sure what we can do for 3.5 anyway.

Comment 4 Richard W.M. Jones 2014-10-29 16:07:54 UTC
(In reply to Omer Frenkel from comment #3)
> Hi Richard, what exactly are you missing that can make debugging easier?
> the message this bug talks about is the message in the ui event log, you
> always have the detailed info in the engine.log

Since writing the comment, we did find engine.log which has more
detail (although it's a lot harder for users to find it).  It would
be good to push the complete reason why the parsed failed (ie. the
lowest level error messages) all the way up to the RHEV-M logs, and
this applies in other areas too.

The name of the OVF file doesn't really matter for virt-v2v, since
we already know that.

At the moment, our OVF files are correct and parsable, so this is
not so much of a problem.

Comment 5 Omer Frenkel 2014-10-29 16:46:28 UTC
Thank you, in that case i'm re-targeting for 3.6, adding the failure msg does make sense, and probably do-able.

Comment 7 Ilanit Stein 2015-10-07 12:10:58 UTC
Verified on rhevm 3.6.0-15:

Corrupted Template brings this event:
Failed to read Template '[Empty Name]' OVF, it may be corrupted. Underlying error message: The markup in the document preceding the root element must be well-formed.

Corrupted Template brings this event:
Failed to read VM '[Empty Name]' OVF, it may be corrupted. Underlying error message: The markup in the document preceding the root element must be well-formed.


Note You need to log in before you can comment on or make changes to this bug.