Bug 1036845 - 'systemctl reload $SERVICE' returns 0 (success) even if ExecReload command returns 1
Summary: 'systemctl reload $SERVICE' returns 0 (success) even if ExecReload command re...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: systemd
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: systemd-maint
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1036848
TreeView+ depends on / blocked
 
Reported: 2013-12-02 18:18 UTC by Arjun Shankar
Modified: 2014-02-24 12:35 UTC (History)
8 users (show)

Fixed In Version: systemd-208-14.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1036848 (view as bug list)
Environment:
Last Closed: 2014-02-24 12:35:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Arjun Shankar 2013-12-02 18:18:59 UTC
Description of problem:

    Even if the command specified in ExecReload in /lib/systemd/system/$SERVICE returns an error, executing 'systemctl reload $SERVICE' always returns 0.

    According to LSB [1], some actions such as 'start', 'stop', 'restart' have exceptions where success is reported irrespective of parts of action failing. But this isn't the case for 'reload'.

Version-Release number of selected component (if applicable):

    systemd-208-6.fc20

How reproducible:

Always

Steps to Reproduce:
    1. # yum install -y nscd
    2. # systemctl stop nscd
    3. # systemctl reload nscd # try to reload a stopped service
    4. # echo $? # check if reload succeeded

Actual results:
    0 # even though all the ExecReload commands return 1 (fail)

Expected results:
    1

Additional info:
[1] http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Comment 1 Zbigniew Jędrzejewski-Szmek 2013-12-03 03:26:04 UTC
Fixed upstream in http://cgit.freedesktop.org/systemd/systemd/commit/?id=6a371e23e.

Comment 2 Fedora Update System 2014-01-15 01:27:17 UTC
systemd-208-11.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-11.fc20

Comment 3 lnie 2014-01-15 03:24:01 UTC
systemd-208-11.fc20 works

Comment 4 Fedora Update System 2014-01-16 07:03:42 UTC
Package systemd-208-11.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-208-11.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0902/systemd-208-11.fc20
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2014-02-17 07:39:48 UTC
systemd-208-13.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-13.fc20

Comment 6 Fedora Update System 2014-02-17 15:08:28 UTC
systemd-208-14.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-14.fc20

Comment 7 Fedora Update System 2014-02-24 12:35:05 UTC
systemd-208-14.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.