Bug 1037277 - Node isn't registred when NIC with VLAN
Summary: Node isn't registred when NIC with VLAN
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: 3.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ---
: 3.3.2
Assignee: Dan Kenigsberg
QA Contact: Haim
URL:
Whiteboard: network
Depends On:
Blocks: 1027349 1037533
TreeView+ depends on / blocked
 
Reported: 2013-12-03 04:04 UTC by Vladimir Tananko
Modified: 2013-12-19 14:24 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
: 1037533 (view as bug list)
Environment:
Last Closed: 2013-12-19 14:24:51 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 21948 0 None None None Never
oVirt gerrit 21982 0 None None None Never

Description Vladimir Tananko 2013-12-03 04:04:23 UTC
Description of problem:
The Node isn't registred in "oVirt Engine" when the network interface card is created with VLAN

Version-Release number of selected component (if applicable):
oVirt Node Hypervisor 3.0.3-1.0.0.fc19

How reproducible:


Steps to Reproduce:
1. Create NIC with VLAN ID.
2. Try Registry Node on oVirt Engine
3.

Actual results:

MainThread::DEBUG::2013-11-28 02:48:30,711::deployUtil::483::root::Bridge ovirtmgmt not found, need to create it.
MainThread::DEBUG::2013-11-28 02:48:30,711::vdsm-reg-setup::80::root::renameBridge begin.
MainThread::DEBUG::2013-11-28 02:48:30,711::deployUtil::1011::root::makeBridge begin.
MainThread::DEBUG::2013-11-28 02:48:30,713::deployUtil::434::root::_getMGTIface: read host name: 172.16.36.240
MainThread::DEBUG::2013-11-28 02:48:30,714::deployUtil::442::root::_getMGTIface: using host name 172.16.36.240 strIP= 172.16.36.240
MainThread::DEBUG::2013-11-28 02:48:30,714::deployUtil::449::root::_getMGTIface IP=172.16.36.240 strIface=eno1.994
MainThread::DEBUG::2013-11-28 02:48:30,715::deployUtil::1055::root::makeBridge found the following bridge paramaters: ['GATEWAY=172.16.36.225', 'IPADDR=172.16.36.226', 'NETMASK=255.255.255.224', 'ONBOOT=yes', 'PEERDNS=no', 'PEERNTP=yes', 'VLAN=yes']
MainThread::DEBUG::2013-11-28 02:48:30,716::utils::489::root::'/sbin/ip -d link show dev eno1.994' (cwd None)
MainThread::DEBUG::2013-11-28 02:48:30,720::utils::509::root::SUCCESS: <err> = ''; <rc> = 0
MainThread::DEBUG::2013-11-28 02:48:30,721::utils::489::root::'/sbin/ip -d link show dev eno1.994' (cwd None)
MainThread::DEBUG::2013-11-28 02:48:30,725::utils::509::root::SUCCESS: <err> = ''; <rc> = 0
MainThread::DEBUG::2013-11-28 02:48:30,725::deployUtil::136::root::['/usr/share/vdsm/addNetwork', 'ovirtmgmt', 994, '', 'eno1', 'GATEWAY=172.16.36.225', 'IPADDR=172.16.36.226', 'NETMASK=255.255.255.224', 'ONBOOT=yes', 'PEERDNS=no', 'PEERNTP=yes', 'VLAN=yes', 'blockingdhcp=true']
MainThread::ERROR::2013-11-28 02:48:30,730::deployUtil::148::root::Traceback (most recent call last):
  File "/usr/share/vdsm-reg/deployUtil.py", line 142, in _logExec
    stderr=subprocess.PIPE)
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
  File "/usr/lib64/python2.7/subprocess.py", line 1308, in _execute_child
TypeError: execv() arg 2 must contain only strings

MainThread::DEBUG::2013-11-28 02:48:30,731::deployUtil::1123::root::makeBridge return.

Expected results:


Additional info:
Patch for vdsm/vdsm_reg/deployUtil.py.in

--- deployUtil.py.in.orig	2013-12-03 06:42:34.708153698 +0400
+++ deployUtil.py.in	2013-12-03 06:48:59.605720754 +0400
@@ -1061,6 +1061,7 @@
         else:
             vlan, bonding, nic = _getRHELBridgeParams(mgtIface,
                                                       bridgeName=bridgeName)
+        vlan = str(vlan)
         fReturn = (nic is not None)
 
     #Delete existing bridge in oVirt

Comment 1 Vladimir Tananko 2013-12-03 04:09:53 UTC
Version-Release number:
ovirt-node-plugin-vdsm-0.1.1-7.fc19.noarch

Comment 2 Dan Kenigsberg 2013-12-03 10:19:02 UTC
Thanks for this report and the accompanying patch.

We have a more problematic case if someone attempts to use the pre-otopi bootstrap code, which may already be installed on his old ovirt-engine. That code expoect netinfo to return vlan ids as strings.

Comment 3 Sandro Bonazzola 2013-12-19 14:24:51 UTC
oVirt 3.3.2 has been released resolving the problem described in this bug report.


Note You need to log in before you can comment on or make changes to this bug.