Description of problem ---------------------- qhull fails to build if "-Werror=format-security" flag is used. ... io.c:2169:3: error: format not a string literal and no format arguments [-Werror=format-security] ... We are working on a proposal to enable "-Werror=format-security" for all packages. Once this flag is enabled, GCC will refuse to compile code that could be vulnerable to a string format security flaw. For more details, please see https://fedorahosted.org/fesco/ticket/1185 page. To understand why it is important to fix this, please see https://fedoraproject.org/wiki/Format-Security-FAQ page. How to fix this --------------- The fix for these errors is quite simple. It's a matter of changing a line like, printf(foo); to read, printf("%s", foo); That's it. Please fix this issue in rawhide with a patch (which you should submit to upstream to merge moving forward). Please do a new build with the fix in rawhide. Other releases do not need to be directly fixed, but there should be no harm in pushing out this fix/patch with other needed changes to those branches. In the event you don't fix this bug before the next mass rebuild, provenpackagers may step in and update your package(s) to fix this issue. How reproducible ---------------- Build qhull-2003.1-22.fc20.src.rpm with "-Werror=format-security" flag to reproduce the problem. To make this process easier, you can use a modified "redhat-rpm-config" package from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL. $ sha256sum redhat-rpm-config-9.1.0-56.fc20.* faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2 redhat-rpm-config-9.1.0-56.fc20.noarch.rpm 5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413 redhat-rpm-config-9.1.0-56.fc20.src.rpm
@Jaromír Cápík: Your patch does not fix any bug. All it does is to pollute 100% correct code with spam originating from GCC not being able properly grok code. The correct work-around to this GCC bug would be not to use -Werror. I hereby formally ask you to revert this change and withdraw YOU the privilege to touch any of my packages without prior permission.
Dear Ralf. I appreciate your passion for Fedora, that made you wait 5 months till the first casualty of your disrespect to the FESCO decision and Fedora Guidelines appeared. We're currently doing a bootstrap of the ppc64le architecture and need to fix hundreds of packages in a ridiculously short time window. Even of that I'm trying to discuss the changes with maintainers each time when I catch them online on the Fedora IRC channels. Leaving any package in the FTBFS state so long without a single comment in bugzilla makes me believe, that you're not interested in Fedora and the Fedora usability anymore. If you believe, that patching the software products is not the right way of doing things, you can fix that by reverting my patch and doing your own flags magic. As it goes against the Fedora guidelines and goals, I'm not going to revert any of my changes, but feel free to break the rules by yourself. Have a nice day, Jaromir.