Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-1.fc21.src.rpm Description: Tracks jobs performed, failed, and the duration of the last 100 jobs for each job type. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6254316
Here's an updated version that follows the latest Ruby guidelines for F21. Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-job-stats.git/commit/?id=6ed5da9da3cfa53765719e5106b2f8b9dd36035b Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6898274
Here's an updated version that works with the newest Redis package in Fedora. Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-job-stats.git/commit/?id=88bfcf7f185b54ae96a34dc402d418c5466842a9 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-job-stats-0.3.0-3.fc22.src.rpm F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7133514
Trying a review... (although unexperienced, I don't have any ruby package yet) Found only cosmetics (nothing needs to be changed): 1) For downloading sources you can consider client that preserves the upstream timestamps: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Timestamps 2) Why is the '%exclude %{gem_instdir}/test' in -doc subpackage? But there is probably no reason why not. Remarks: * You're patching out development files in %prep. It is true it may be better than using %exclude in %files, right? (Files won't be installed, they won't be there during testing...). * %check section: It looks like redis-server listens only on IPv4 and communication during testing goes through 127.0.0.1. But it works well in koji and even on IPv6-only machine. Would you agree for review swap with rubygem-json_spec (#1079640)? But I can do formal review here anyway. :-) Thank you, František
I know the formal process of review has not started, but I guess this review can be considered as stalled and closed. But I can review, if you're interested in it. Over time there are some new issues to consider, for example: * %license tag has been added into guidelines * Fedora 20 conditional macros can be removed * upstream searches for new maintainer