Spec URL: http://rdieter.fedorapeople.org/rpms/kde-touchpad-config/kde-touchpad-config.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kde-touchpad-config/kde-touchpad-config-0-1.20131204git3f60a6e9.fc20.src.rpm Description: KDE Systemsettings module for touchpads Fedora Account System Username: rdieter
Scratch build: http://rdieter.fedorapeople.org/rpms/kde-touchpad-config/kde-touchpad-config-0-1.20131204git3f60a6e9.fc20.src.rpm Some (mostly runtime) caveats with this, that I documented in the .spec, but will do so here too: ## This will likely deprecate/replace kcm_touchpad eventually, but only after testing #Obsoletes: kcm_touchpad < 0.3.1-50 #Provides: kcm_touchpad = 0.3.2-%{release} ## current caveats # * no translations # * dell/lenovo pointing sticks identify as plugged-in mice, so touchpad gets disabled by default-on option "disable touchpad when mouse is plugged in" # * kcm always gives warning "Saved configuration differs from active configuration"
(In reply to Rex Dieter from comment #1) > # * dell/lenovo pointing sticks identify as plugged-in mice, so touchpad > gets disabled by default-on option "disable touchpad when mouse is plugged > in" > # * kcm always gives warning "Saved configuration differs from active > configuration" This I would consider as blockers for the time being. A lot of users have Lenovo laptops. They would be very annoyed if they could only use the trackpoint or the touchpad, not both at the same time. Well, on my T61 I've disabled the touchpad completely, but I don't expect that from most users. The behavior and stability needs to be tested in any case before we replace kcm_touchpad.
I can put hands on ~7-10 different Thinkpads. Let me know if you need any kind of testing.
What is needed most right now is a package review. Once in the distro (rawhide), then we can start testing things in earnest.
Spec URL: http://rdieter.fedorapeople.org/rpms/kcm-touchpad/kcm-touchpad.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kcm-touchpad/kcm-touchpad-1.0-1.fc20.src.rpm %changelog * Thu Apr 03 2014 Rex Dieter <rdieter> 1.0-1 - kcm-touchpad-1.0
*** Bug 1091760 has been marked as a duplicate of this bug. ***
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/admiller/reviews/1038238-kcm-touchpad/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/kde4/apps/kcm_touchpad [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/kde4/apps/kcm_touchpad, /usr/share/dbus-1, /usr/share/dbus-1/interfaces, /usr/share/kde4/apps/plasma/plasmoids [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in kcm-touchpad [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kcm-touchpad-1.0-1.fc21.x86_64.rpm kcm-touchpad-1.0-1.fc21.src.rpm kcm-touchpad.x86_64: W: spelling-error Summary(en_US) touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.x86_64: W: spelling-error %description -l en_US touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/devices/input-touchpad.svgz kcm-touchpad.x86_64: W: no-manual-page-for-binary kcm-touchpad-list-devices kcm-touchpad.src: W: spelling-error Summary(en_US) touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.src: W: spelling-error %description -l en_US touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.src:16: W: macro-in-comment %{release} 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint kcm-touchpad kcm-touchpad.x86_64: W: spelling-error Summary(en_US) touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.x86_64: W: spelling-error %description -l en_US touchpads -> touch pads, touch-pads, touchpapers kcm-touchpad.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/devices/input-touchpad.svgz kcm-touchpad.x86_64: W: no-manual-page-for-binary kcm-touchpad-list-devices 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- kcm-touchpad (rpmlib, GLIBC filtered): /bin/sh kde-runtime libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtSvg.so.4()(64bit) libX11-xcb.so.1()(64bit) libX11.so.6()(64bit) libXi.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libknotifyconfig.so.4()(64bit) libm.so.6()(64bit) libplasma.so.3()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libxcb-record.so.0()(64bit) libxcb.so.1()(64bit) plasma4(scriptengine-declarativeappletscript) rtld(GNU_HASH) Provides -------- kcm-touchpad: kcm-touchpad kcm-touchpad(x86-64) plasma4(applet-touchpad) plasma4(dataengine-touchpad) Unversioned so-files -------------------- kcm-touchpad: /usr/lib64/kde4/kded_touchpad.so kcm-touchpad: /usr/lib64/kde4/plasma_engine_touchpad.so Source checksums ---------------- http://rdieter.fedorapeople.org/kcm-touchpad/kcm-touchpad-1.0.tar.xz : CHECKSUM(SHA256) this package : 063017262fb8e802c1633d32fd5b987ea320fb86cbffc51e134878625a41c1ca CHECKSUM(SHA256) upstream package : 063017262fb8e802c1633d32fd5b987ea320fb86cbffc51e134878625a41c1ca Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1038238 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ================================================== NOTES: From a package point of view it looks good, but I would like to know how to properly test it so that I can switch the '?' to 'x' in the following item: [?]: Package functions as described.
Sorry, I forgot to close this. We'd opted to import this into the existing kcm_touchpad git module, instead of going through a new review largely to rename it to kcm-touchpad instead. Hit me up on irc if you're interested in a scratch build for testing (say, on f20 or whatever).