Red Hat Bugzilla – Bug 1039081
Please remove "path" and "relative-to" attributes from CLI.
Last modified: 2015-07-09 02:33:24 EDT
Description of problem: As "process-id/file" functionality is not yet added in EAP, the "path" and "relative-to" attributes are useless in transactions subsystem of CLI. Please remove them. Also please remove them from "jboss-as-txn***.xsd" file as well.
We cannot remove these without breaking API. Whether they do anything or not, they are part of the API. We could change the subsystem to annotate them as deprecated and log a WARN or INFO message if they are set. And remove them from the next version of the xsd and the parser for that (but they remain in the previous xsds and their associated parsers.) But does it make more sense to instead spend that energy actually exposing the process-id/file functionality? Note that the CoreEnvironmentBean varDir property that these attribute feed says nothing about being limited in use only to process-id/file functionality. So before making any change I'd need to see a clear statement from the Narayana team that it's safe to no longer set the property and will remain safe.
Hi Brian, There are two relative-to settings. One called object-store-relative-to and that still should work. There is also a relative-to for the core environment service which is not used. The only process ID types we use are the uuid method and the socket process method. relative-to and path although modifiable would have no affect on the transaction manager. I think it must have been there since the start when all the config must have been converted. It would not ever activate though. I realise you assigned it to me, do you want us to deprecate it or are you happy to? Thanks, Tom
Hi Tom, I'll take care of the deprecation.
Thanks Brian - much appreciated
Pull request to deprecate these is https://github.com/jbossas/jboss-eap/pull/1311. I'm not moving this to POST status though or scheduling for 6.3 as this deprecation work is just step one; the requested removal will be in a later release.
Is it normal to leave a BZ open once the code is deprecated? I would expect there is some process to sweep these at a later date? If not, please can we update this to TBDEAP7?
Added flags to get the deprecated code release noted
Just to confirm that the deprecation has been done for EAP 6 and the actual removal will not be done for EAP6 but for EAP7. I just need to get the release notes update to reflect the fact the deprecation was done.
Created a WFLY issue for this could be fixed for EAP7 https://issues.jboss.org/browse/WFLY-4445
Deferred to https://issues.jboss.org/browse/WFLY-4445
Amos Feng <zfeng@redhat.com> updated the status of jira WFLY-4445 to Coding In Progress