Hide Forgot
# Spec URL # https://github.com/ryanlerch/my-fedora-package-reviews/blob/master/key-mon/key-mon.spec # SRPM URL # https://github.com/ryanlerch/my-fedora-package-reviews/raw/master/key-mon/key-mon-1.16-0.fc20.src.rpm # Description # Key-mon is useful for teaching since it shows the current status of your keyboard and mouse and you use them in another application. No longer do you need to say 'Now I'm pressing the Ctrl-D key', your students can just see the keystroke for themselves. # Fedora Account System Username # ryanlerch
I like this package, it's really useful for me! 1. Release: 0%{?dist} Remember to change it to 1 in SCM ;) 2. Source0: http://key-mon.googlecode.com/files/key-mon-1.16.tar.gz As gcode will shut down the download section from 2014 as well as this is a python package, you can find it in the Package Index(pypi): https://pypi.python.org/pypi/key-mon So please change the Source0 to: https://pypi.python.org/packages/source/k/key-mon/key-mon-%{version}.zip 3. BuildRequires: desktop-file-utils %description Leave a blank line between each other. 4. for lib in %{buildroot}%{python2_sitelib}/keymon/*.py; do sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done Well, please do this in %prep, don't do that after %build 5. %doc only has an reStructuredText file of README, please also include COPYING. 6. You should ship manpage also. Also seems it's useless ;) 7. From the homepage, you've missed some Requires: pygtk2 python-xlib librsvg2 8. Patch binary key-mon to %{__python2} as well.
(In reply to Christopher Meng from comment #1) new SRPM and SPEC are available here: https://github.com/ryanlerch/my-fedora-package-reviews/tree/master/key-mon > I like this package, it's really useful for me! > > 1. Release: 0%{?dist} > > Remember to change it to 1 in SCM ;) Done in commits: https://github.com/ryanlerch/my-fedora-package-reviews/commit/aa242b098373ebd2a1ea2920c3d25e7486146284 https://github.com/ryanlerch/my-fedora-package-reviews/commit/09225aec49e5b9108f8cb011ad9e6375c020df25 > > 2. Source0: > http://key-mon.googlecode.com/files/key-mon-1.16.tar.gz > > As gcode will shut down the download section from 2014 as well as this is a > python package, you can find it in the Package Index(pypi): > > https://pypi.python.org/pypi/key-mon > > So please change the Source0 to: > > https://pypi.python.org/packages/source/k/key-mon/key-mon-%{version}.zip done in commit: https://github.com/ryanlerch/my-fedora-package-reviews/commit/013e61f21c6c8850359e099c319ae42fa29028ba > > 3. BuildRequires: desktop-file-utils > %description > > Leave a blank line between each other. https://github.com/ryanlerch/my-fedora-package-reviews/commit/4d54c39eb164b362bf97d4d5fa76c975bc2dbef9 > > 4. for lib in %{buildroot}%{python2_sitelib}/keymon/*.py; do > sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new && > touch -r $lib $lib.new && > mv $lib.new $lib > done > > Well, please do this in %prep, don't do that after %build https://github.com/ryanlerch/my-fedora-package-reviews/commit/7ce990a0cccc76c6b93ba958e825fb6688dafbbd > > 5. %doc only has an reStructuredText file of README, please also include > COPYING. https://github.com/ryanlerch/my-fedora-package-reviews/commit/b25e83b7646ee01645bec19383f71be1f514c6bc > > 6. You should ship manpage also. Also seems it's useless ;) https://github.com/ryanlerch/my-fedora-package-reviews/commit/271e5d29e69cb2d72044d7918ae40074e3f38e1f > > 7. From the homepage, you've missed some Requires: > > pygtk2 > python-xlib > librsvg2 Added in https://github.com/ryanlerch/my-fedora-package-reviews/commit/b837a259fd5ffb90da34d920933bd8ae9c2e48b4 however, this does now cause RPMLINT to spew the following errors: """ Rpmlint ------- Checking: key-mon-1.16-1.fc20.noarch.rpm key-mon-1.16-1.fc20.src.rpm key-mon.noarch: E: explicit-lib-dependency librsvg2 key-mon.noarch: E: explicit-lib-dependency python-xlib 2 packages and 0 specfiles checked; 2 errors, 0 warnings. """ > > 8. Patch binary key-mon to %{__python2} as well. Done in https://github.com/ryanlerch/my-fedora-package-reviews/commit/f0d823db351ecfa760cf70e2fd2ed8d0a68f5c62 however, i did check the key-mon file in the bin directory before i added the above commit and the first line was already "#!/usr/bin/python2". Is rpm already doing this patching for me?
Then you don't need to patch it any more. %__python2 executable had done works for you. PACKAGE APPROVED.
You forget this one.
New Package SCM Request ======================= Package Name: key-mon Short Description: A screen cast utility that displays your keyboard and mouse status Owners: ryanlerch Branches: f19 f20
Git done (by process-git-requests).
key-mon-1.16-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/key-mon-1.16-1.fc19
key-mon-1.16-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/key-mon-1.16-1.fc20
Please update to 1.17! :(
(In reply to Christopher Meng from comment #9) > Please update to 1.17! :( I saw that before i Pushed the update, however looking at the release notes, it seems that update does not actaully *fix* anything, just add a few more themes, so i decided to push the package with 1.16, and work on the updating it soon. from the key-mon release notes: Jan 07, 2014 v 1.17 -------------------- * Added hi-color icons (thanks eko). * Added big-letters theme (thanks eko). * Bumped the version. regards, ryanlerch
key-mon-1.16-1.fc20 has been pushed to the Fedora 20 stable repository.
key-mon-1.16-1.fc19 has been pushed to the Fedora 19 stable repository.
*** Bug 592628 has been marked as a duplicate of this bug. ***