Bug 1039163 - Review Request: python-fuckit - The Python Error Steamroller
Summary: Review Request: python-fuckit - The Python Error Steamroller
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralph Bean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-06 19:43 UTC by Ian Weller
Modified: 2014-11-10 06:12 UTC (History)
3 users (show)

Fixed In Version: python-fuckit-4.8.0-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-07 02:37:10 UTC
Type: ---
Embargoed:
rbean: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Ralph Bean 2013-12-10 16:44:12 UTC
A couple of issues:

- Should this package instead be named python-fuckitpy?  I know some python modules do not have the python- prefix, but it is my understanding that they have been grandfathered in and that all new packages should have such a prefix.
The naming guidelines are not particularly clear on it:  https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29

- Instead of using 'python' directly you should use the %{__python2} macro everywhere to be ready for python3 as default in future Fedora releases.

- Same goes for using %{python2_sitelib} instead of %{python_sitelib}.

- Lastly, the file ownership should be more specific.  Own %{python2_sitelib}/fuckit.py and/or the egg, not just '*' please.  This helps future readers of your spec file understand what is getting installed.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[-]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 5 files have unknown license. Detailed output of
     licensecheck in /home/threebean/1039163-fuckitpy/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: fuckitpy-1.0.0-1.20131206gitb8cf18f.fc19.noarch.rpm
          fuckitpy-1.0.0-1.20131206gitb8cf18f.fc19.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint fuckitpy
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
fuckitpy (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
fuckitpy:
    fuckitpy



Source checksums
----------------
https://github.com/ajalt/fuckitpy/archive/b8cf18ff620f8fe19c4456c3c1ac490724513197/fuckitpy-1.0.0-b8cf18f.tar.gz :
  CHECKSUM(SHA256) this package     : 4f8d987d4574704e20d66875e520c02da623cfbc9e640b02dc10628974d426c4
  CHECKSUM(SHA256) upstream package : 4f8d987d4574704e20d66875e520c02da623cfbc9e640b02dc10628974d426c4


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1039163
Buildroot used: fedora-19-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 2 Ian Weller 2014-09-17 21:10:30 UTC
Spec URL: http://ianweller.org/files/SRPMS/python-fuckit/4.8.0-1/python-fuckit.spec
SRPM URL: http://ianweller.org/files/SRPMS/python-fuckit/4.8.0-1/python-fuckit-4.8.0-1.fc20.src.rpm

* Mon Sep 15 2014 Ian Weller <ian> - 4.8.0-1
- Update to 4.8.0 and fix packaging concerns

Comment 3 Ralph Bean 2014-09-18 02:02:22 UTC
Thanks.  Package Approved!

Comment 4 Ian Weller 2014-09-18 05:53:24 UTC
New Package SCM Request
=======================
Package Name: python-fuckit
Short Description: The Python Error Steamroller
Upstream URL: https://github.com/ajalt/fuckitpy
Owners: ianweller
Branches: f20 f21 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-09-18 11:48:54 UTC
Git done (by process-git-requests).

Comment 6 Ralph Bean 2014-10-22 03:16:21 UTC
It's been a month since the git request was processed.  Any problems getting this built for rawhide and closed?

Comment 7 Ian Weller 2014-10-22 19:18:23 UTC
It's built for rawhide (I think) [1] -- I need to get a fix in for building on epel7 (and discover what the fix is to begin with), and push a newpackage update for the other Fedora branches. As such I'll mark this as MODIFIED.

Thanks for the reminder!

[1]: http://koji.fedoraproject.org/koji/buildinfo?buildID=582984

Comment 8 Fedora Update System 2014-10-23 20:24:03 UTC
python-fuckit-4.8.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-fuckit-4.8.0-1.fc20

Comment 9 Fedora Update System 2014-10-23 20:24:09 UTC
python-fuckit-4.8.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-fuckit-4.8.0-1.fc21

Comment 10 Fedora Update System 2014-10-27 08:18:20 UTC
Package python-fuckit-4.8.0-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-fuckit-4.8.0-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-13655/python-fuckit-4.8.0-1.fc21
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2014-11-07 02:37:10 UTC
python-fuckit-4.8.0-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2014-11-10 06:12:05 UTC
python-fuckit-4.8.0-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.