Bug 1039491 - "ValueError: new size same as old size" if you set a volume to 'Shrink' but do not change its size, in Reclaim Space
Summary: "ValueError: new size same as old size" if you set a volume to 'Shrink' but d...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 20
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vratislav Podzimek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:8e273c2252b32c5d344785b3281...
Depends On:
Blocks: F20FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2013-12-09 09:20 UTC by Alexey Torkhov
Modified: 2013-12-13 05:33 UTC (History)
10 users (show)

Fixed In Version: anaconda-20.25.15-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-13 05:33:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (863.21 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: anaconda.log (12.67 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: environ (525 bytes, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: journalctl (317.14 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: lsblk_output (2.76 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: nmcli_dev_list (4.33 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: os_info (375 bytes, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: program.log (86.98 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: storage.log (401.62 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details
File: ifcfg.log (3.27 KB, text/plain)
2013-12-09 09:20 UTC, Alexey Torkhov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1040012 0 unspecified CLOSED SizeNotPositiveError: spec= param must be >=0 2021-02-22 00:41:40 UTC

Internal Links: 1040012

Description Alexey Torkhov 2013-12-09 09:20:08 UTC
Description of problem:
Trying to resize partition that is filled up to 100%

Version-Release number of selected component:
anaconda-20.25.14-1.fc20.x86_64

The following was filed automatically by anaconda:
anaconda 20.25.14-1 exception report
Traceback (most recent call first):
  File "/usr/lib/python2.7/site-packages/blivet/deviceaction.py", line 390, in __init__
    raise ValueError("new size same as old size")
  File "/usr/lib/python2.7/site-packages/blivet/__init__.py", line 1253, in resizeDevice
    self.devicetree.registerAction(action_class(device, new_size))
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/resize.py", line 392, in _scheduleActions
    self.storage.resizeDevice(device, obj.target)
ValueError: new size same as old size

Additional info:
cmdline:        /usr/bin/python  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   initrd=initrd0.img root=live:CDLABEL=Fedora-Live-KDE-x86_64-20-TC5 rootfstype=auto ro rd.live.image quiet  rhgb rd.luks=0 rd.md=0 rd.dm=0  BOOT_IMAGE=vmlinuz0 
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         3.11.10-300.fc20.x86_64
other involved packages: python-blivet-0.23.8-1.fc20.noarch
product:        Fedora
release:        Fedora release 20 (Heisenbug)
type:           anaconda
version:        20

Comment 1 Alexey Torkhov 2013-12-09 09:20:15 UTC
Created attachment 834260 [details]
File: anaconda-tb

Comment 2 Alexey Torkhov 2013-12-09 09:20:19 UTC
Created attachment 834261 [details]
File: anaconda.log

Comment 3 Alexey Torkhov 2013-12-09 09:20:24 UTC
Created attachment 834262 [details]
File: environ

Comment 4 Alexey Torkhov 2013-12-09 09:20:28 UTC
Created attachment 834263 [details]
File: journalctl

Comment 5 Alexey Torkhov 2013-12-09 09:20:31 UTC
Created attachment 834264 [details]
File: lsblk_output

Comment 6 Alexey Torkhov 2013-12-09 09:20:34 UTC
Created attachment 834265 [details]
File: nmcli_dev_list

Comment 7 Alexey Torkhov 2013-12-09 09:20:39 UTC
Created attachment 834266 [details]
File: os_info

Comment 8 Alexey Torkhov 2013-12-09 09:20:42 UTC
Created attachment 834267 [details]
File: program.log

Comment 9 Alexey Torkhov 2013-12-09 09:20:45 UTC
Created attachment 834268 [details]
File: storage.log

Comment 10 Alexey Torkhov 2013-12-09 09:20:47 UTC
Created attachment 834269 [details]
File: ifcfg.log

Comment 11 Fedora Blocker Bugs Application 2013-12-09 09:22:20 UTC
Proposed as a Blocker for 20-final by Fedora user atorkhov using the blocker tracking app because:

 Reject or disallow invalid disk and volume configurations without crashing.

Comment 12 Kamil Páral 2013-12-09 17:00:03 UTC
I can't reproduce this with F20 TC5 x86_64 Live.

I created an ext4 partition covering the whole disk. I used fallocate and dd (to fill the rest) to create files taking up all space. Anaconda doesn't allow me to use the reclaim dialog (the reclaim button is grayed out) and in the custom partitioning when I try to downsize the partition, the size is reverted to original. No crash, behaves as expected.

Alexey, you need to be more detailed in the reproduction steps. Thanks.

Comment 13 Mike Ruckman 2013-12-09 17:55:38 UTC
Discussed in 2013-12-09 Blocker Review meeting [1]. Voted to punt because there is insufficient information available on #1039491 for now, it was not immediately reproducible: delaying decision until wednesday, greenlion will try to come up with a reliable reproducer

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2013-12-09/

Comment 14 Alexey Torkhov 2013-12-09 21:51:42 UTC
(In reply to Kamil Páral from comment #12)
> Alexey, you need to be more detailed in the reproduction steps. Thanks.

Seems that it enable reclaim button only after free space is enough to install. And also if some correct operation on other partition is involved too. Here are steps I'm using to reproduce:

1. On disk of size 8G create two partitions of size 500M. Fill 100% one of them
2. Start installer, go to reclaim space dialog
3. Press shrink on 100% filled - it won't allow to select size, but changes partition action to "Shrink"
4. Press delete on other one - it will enable reclaim space button.

Comment 15 Alexey Torkhov 2013-12-09 21:58:19 UTC
This criteria seems to be more fitting:

 Any installer mechanism for resizing storage volumes must correctly attempt the requested operation.

It allows shrink operation on 100% filled partition to be requested, so it must be correctly attempted.

Comment 16 Alexey Torkhov 2013-12-10 12:25:19 UTC
It does behave same with any kind of partitions, not only 100% full.

Comment 17 Alexey Torkhov 2013-12-10 14:41:20 UTC
As seems it does matter that tools are used to create partitions, I used fdisk&mkfs.ext4.

Comment 18 Kamil Páral 2013-12-10 14:59:48 UTC
Reproducing bug 1039491. I had two partitions, both of them empty (not 100%, not needed). I clicked on Shrink on the first one, but didn't move the slider (that's the point), and clicked on Delete on the second one. Crashed after Reclaim space. Anaconda doesn't take into account that someone might set to shrink a partition, but then not adjust the size at all (and other selected operations allow him to continue and confirm this).

cmdline:        /usr/bin/python  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   initrd=initrd0.img root=live:CDLABEL=Fedora-Live-Desktop-x86_64-20-TC rootfstype=auto ro rd.live.image quiet  rhgb rd.luks=0 rd.md=0 rd.dm=0  BOOT_IMAGE=vmlinuz0 
hashmarkername: anaconda
kernel:         3.11.10-300.fc20.x86_64
other involved packages: python-blivet-0.23.8-1.fc20.noarch
package:        anaconda-20.25.14-1.fc20.x86_64
packaging.log:  
product:        Fedora
reason:         ValueError: new size same as old size
release:        Fedora release 20 (Heisenbug)
version:        20

Comment 19 Adam Williamson 2013-12-10 17:15:41 UTC
Reproduced here too. FWIW, this bug is also present in Fedora 19. This is another borderline blocker call for me...I'd like us not to be releasing with this kind of bug, but it depends if we have the will to delay to fix them...guess I'd shade +1, though.

Comment 20 Vratislav Podzimek 2013-12-11 11:05:58 UTC
Please try this updates.img:
http://vpodzime.fedorapeople.org/f20_blockers_updates.img

Comment 21 Lukas Brabec 2013-12-11 11:46:24 UTC
(In reply to Vratislav Podzimek from comment #20)
> Please try this updates.img:
> http://vpodzime.fedorapeople.org/f20_blockers_updates.img

it seems that this fixes the bug

Comment 22 Mike Ruckman 2013-12-11 17:57:56 UTC
Discussed in 2013-12-11 Blocker Review Meeting [1]. Voted as an RejectedBlocker and a AcceptedFreezeException. This is inconvenient, but quite unlikely to hit. It also doesn't present any user data loss. A patch will be considered.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2013-12-11/

Comment 23 Fedora Update System 2013-12-11 22:48:28 UTC
anaconda-20.25.15-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.25.15-1.fc20

Comment 24 Adam Williamson 2013-12-11 23:28:09 UTC
Fix verified with a test image built with 20.25.15-1.

Comment 25 Fedora Update System 2013-12-13 05:33:53 UTC
anaconda-20.25.15-1.fc20, python-blivet-0.23.9-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.