Bug 1039584 - [new relic] TermsController#create raised NoMethodError: undefined method `each' for nil:NilClass
Summary: [new relic] TermsController#create raised NoMethodError: undefined method `ea...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Management Console
Version: 1.x
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Clayton Coleman
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-09 14:35 UTC by Jessica Forrester
Modified: 2014-01-30 00:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-30 00:52:41 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Jessica Forrester 2013-12-09 14:35:42 UTC
Description of problem:
In PROD, TermsController#create raised NoMethodError: undefined method `each' for nil:NilClass 

Reference id: 4e919e9ceb084b9c5fa9988a11409651

Stacktrace:
…www/openshift/site/app/controllers/
terms_controller.rb:  52:in `create'
…sr/share/gems/gems/journey-1.0.4/lib/journey/
router.rb:  68:in `block in call'
…sr/share/gems/gems/journey-1.0.4/lib/journey/
router.rb:  56:in `each'
…sr/share/gems/gems/journey-1.0.4/lib/journey/
router.rb:  56:in `call'
…e/gems/gems/rack-recaptcha-0.6.5/lib/rack/
recaptcha.rb:  50:in `_call'
…e/gems/gems/rack-recaptcha-0.6.5/lib/rack/
recaptcha.rb:  37:in `call'
…3/root/usr/share/gems/gems/rack-1.4.1/lib/rack/
etag.rb:  23:in `call'
…/share/gems/gems/rack-1.4.1/lib/rack/
conditionalget.rb:  35:in `call'
…e/gems/gems/rack-1.4.1/lib/rack/session/abstract/
id.rb: 205:in `context'
…e/gems/gems/rack-1.4.1/lib/rack/session/abstract/
id.rb: 200:in `call'
…ot/usr/share/gems/gems/rack-1.4.1/lib/rack/
sendfile.rb: 102:in `call'
…/share/gems/gems/rack-1.4.1/lib/rack/
methodoverride.rb:  21:in `call'
…oot/usr/share/gems/gems/rack-1.4.1/lib/rack/
runtime.rb:  17:in `call'
…are/gems/gems/rack-cache-1.2/lib/rack/cache/
context.rb: 136:in `forward'
…are/gems/gems/rack-cache-1.2/lib/rack/cache/
context.rb: 143:in `pass'
…are/gems/gems/rack-cache-1.2/lib/rack/cache/
context.rb: 155:in `invalidate'
…are/gems/gems/rack-cache-1.2/lib/rack/cache/
context.rb:  71:in `call!'
…are/gems/gems/rack-cache-1.2/lib/rack/cache/
context.rb:  51:in `call'
…r-3.0.21/lib/phusion_passenger/rack/
request_handler.rb:  97:in `process_request'
…0.21/lib/phusion_passenger/
abstract_request_handler.rb: 521:in `accept_and_process_next_request'
…0.21/lib/phusion_passenger/
abstract_request_handler.rb: 274:in `main_loop'
…0.21/lib/phusion_passenger/rack/
application_spawner.rb: 206:in `start_request_handler'
…0.21/lib/phusion_passenger/rack/
application_spawner.rb:  79:in `block in spawn_application'
…s/gems/passenger-3.0.21/lib/phusion_passenger/
utils.rb: 470:in `safe_fork'
…0.21/lib/phusion_passenger/rack/
application_spawner.rb:  64:in `spawn_application'
…assenger-3.0.21/lib/phusion_passenger/
spawn_manager.rb: 264:in `spawn_rack_application'
…assenger-3.0.21/lib/phusion_passenger/
spawn_manager.rb: 137:in `spawn_application'
…assenger-3.0.21/lib/phusion_passenger/
spawn_manager.rb: 275:in `handle_spawn_application'
…senger-3.0.21/lib/phusion_passenger/
abstract_server.rb: 357:in `server_main_loop'
…senger-3.0.21/lib/phusion_passenger/
abstract_server.rb: 206:in `start_synchronously'

Comment 2 Clayton Coleman 2013-12-18 02:45:42 UTC
Fixed in https://github.com/openshift/li/pull/2244

Comment 3 Yujie Zhang 2013-12-18 10:05:12 UTC
(In reply to Clayton Coleman from comment #2)
hi Clayton, can you give me some suggestions about adding errors to user besides using your terms_controller_test.rb script? I will verify this bug after the code is merged, thanks.

Comment 4 openshift-github-bot 2013-12-18 17:24:22 UTC
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/3a56e1d34dc2e0fe603be661d7a9baf87c17ed3b
Bug 1039584 - Error case was generating invalid page

Comment 5 Yujie Zhang 2013-12-19 02:54:36 UTC
Tested on devenv_4154, ran the test script terms_controller_test.rb, it can pass without error, so verify this bug, thanks.

Comment 6 Clayton Coleman 2013-12-20 00:41:37 UTC
Unfortunately no - the streamline service would have to fail in order to trigger this.  You may be able to set up a proxy server (in front of streamline-ops1.rhcloud.com" and then turn it off during a terms acceptance, but it's tough.


Note You need to log in before you can comment on or make changes to this bug.