Bug 1039728 - SizeNotPositiveError: spec= param must be >=0 - in reclaim space dialog on device that contains filesystem that is larger that its container
Summary: SizeNotPositiveError: spec= param must be >=0 - in reclaim space dialog on de...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 20
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:e684994da4839efdc0b044bcf18...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-09 21:09 UTC by Alexey Torkhov
Modified: 2014-02-28 23:04 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-02-28 23:04:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (597.06 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: anaconda.log (15.36 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: environ (525 bytes, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: journalctl (252.06 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: lsblk_output (2.28 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: nmcli_dev_list (4.33 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: os_info (375 bytes, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: program.log (55.90 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: storage.log (230.40 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details
File: ifcfg.log (3.43 KB, text/plain)
2013-12-09 21:10 UTC, Alexey Torkhov
no flags Details

Description Alexey Torkhov 2013-12-09 21:09:57 UTC
Description of problem:
Go to reclaim space on a device that contains a filesystem that is larger that its container.

Version-Release number of selected component:
anaconda-20.25.14-1.fc20.x86_64

The following was filed automatically by anaconda:
anaconda 20.25.14-1 exception report
Traceback (most recent call first):
  File "/usr/lib/python2.7/site-packages/blivet/size.py", line 96, in _parseSpec
    raise SizeNotPositiveError("spec= param must be >=0")
  File "/usr/lib/python2.7/site-packages/blivet/size.py", line 164, in __new__
    self = Decimal.__new__(cls, value=_parseSpec(en_spec, False))
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/lib/disks.py", line 80, in size_str
    size = Size(en_spec="%f mb" % mb)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/resize.py", line 155, in populate
    % {"freeSize": size_str(freeSize), "devSize": size_str(dev.size)}
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/resize.py", line 299, in refresh
    self.populate(disks)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 919, in _show_resize_dialog
    resizeDialog.refresh(disks)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 872, in on_back_clicked
    if not self._show_resize_dialog(disks):
SizeNotPositiveError: spec= param must be >=0

Additional info:
cmdline:        /usr/bin/python  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   initrd=initrd0.img root=live:CDLABEL=Fedora-Live-KDE-x86_64-20-TC5 rootfstype=auto ro rd.live.image quiet  rhgb rd.luks=0 rd.md=0 rd.dm=0  BOOT_IMAGE=vmlinuz0 
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         3.11.10-300.fc20.x86_64
other involved packages: python-blivet-0.23.8-1.fc20.noarch
product:        Fedora
release:        Fedora release 20 (Heisenbug)
type:           anaconda
version:        20

Comment 1 Alexey Torkhov 2013-12-09 21:10:03 UTC
Created attachment 834536 [details]
File: anaconda-tb

Comment 2 Alexey Torkhov 2013-12-09 21:10:06 UTC
Created attachment 834537 [details]
File: anaconda.log

Comment 3 Alexey Torkhov 2013-12-09 21:10:08 UTC
Created attachment 834538 [details]
File: environ

Comment 4 Alexey Torkhov 2013-12-09 21:10:12 UTC
Created attachment 834539 [details]
File: journalctl

Comment 5 Alexey Torkhov 2013-12-09 21:10:14 UTC
Created attachment 834540 [details]
File: lsblk_output

Comment 6 Alexey Torkhov 2013-12-09 21:10:16 UTC
Created attachment 834541 [details]
File: nmcli_dev_list

Comment 7 Alexey Torkhov 2013-12-09 21:10:18 UTC
Created attachment 834542 [details]
File: os_info

Comment 8 Alexey Torkhov 2013-12-09 21:10:21 UTC
Created attachment 834543 [details]
File: program.log

Comment 9 Alexey Torkhov 2013-12-09 21:10:24 UTC
Created attachment 834544 [details]
File: storage.log

Comment 10 Alexey Torkhov 2013-12-09 21:10:26 UTC
Created attachment 834545 [details]
File: ifcfg.log

Comment 11 Alexey Torkhov 2013-12-09 21:20:28 UTC
Steps to reproduce:

1. Create a partition with ext4 filesystem of, say, 8G. Do something on it.
2. Delete that partition. Recreate it with same start and 500M size.
3. Start installer, go to reclaim space. (Didn't want to resize it, just delete.)
It crashes.

Anyway, proposing as a blocker due to:

 When using the guided partitioning flow, the installer must be able to: 
 Cleanly install to a disk with a valid ms-dos or gpt disk label and partition table which contains existing data and sufficient unpartitioned space for a Fedora installation

It doesn't say that filesystems must be correct.

Has same summary as bug 1038847 but crashes from different operation.

Comment 12 Kamil Páral 2013-12-10 15:11:30 UTC
Are you trying to say that you kept the 8 GB ext4 filesystem, but shrunk the underlying partition to 500 MB? That is certainly an invalid setup. It would be nice if anaconda didn't crash on start, sure. But I don't think such malicious attempts are covered by our release criteria.

Comment 13 Alexey Torkhov 2013-12-10 15:17:17 UTC
(In reply to Kamil Páral from comment #12)
> Are you trying to say that you kept the 8 GB ext4 filesystem, but shrunk the
> underlying partition to 500 MB? That is certainly an invalid setup. It would
> be nice if anaconda didn't crash on start, sure. But I don't think such
> malicious attempts are covered by our release criteria.

Yes, true. But then criteria might need to be reworded to cover filesystems too, not only partition table.

Comment 14 Vratislav Podzimek 2013-12-10 16:30:27 UTC
I just hope this is rejected as final blocker

Comment 15 Adam Williamson 2013-12-10 17:25:03 UTC
yeah, I'd be -1 on this.

look, writing criteria is *hard enough* without people apparently trying intentionally to game them. please give them a bit of leeway, unless you want the criteria to wind up looking like a legal code: 900 pages long and hedged around with impenetrable language meant to cover every goddamn eventuality. I can write an explicit 'the partitions must not be weirdly hacked up to be invalid' clause into the criteria or we can stop trying to poke holes in the goddamn language and keep them short...

Comment 16 Alexey Torkhov 2013-12-10 17:48:43 UTC
Okay-okay, lifting it.

Comment 17 David Shea 2014-02-28 23:04:42 UTC
This exception no longer exists.


Note You need to log in before you can comment on or make changes to this bug.