Bug 1039757 - Metric graph is missing from summary portlet chart if it has been opened on monitoring page
Summary: Metric graph is missing from summary portlet chart if it has been opened on m...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Monitoring -- Other, UI
Version: JON 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: DR01
: JON 3.2.1
Assignee: Mike Thompson
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-09 22:22 UTC by Larry O'Leary
Modified: 2014-05-08 17:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-08 17:43:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screen-shot showing missing graph on metric chart (78.98 KB, image/png)
2013-12-09 22:27 UTC, Larry O'Leary
no flags Details

Description Larry O'Leary 2013-12-09 22:22:28 UTC
Description of problem:
The metric chart displayed when clicking on a metric available on the resource's summary portlet is missing its metric graph if the metric's graph was already expanded/opened on the resource's monitoring page.

The only thing visible on the chart is a availability chart.

Version-Release number of selected component (if applicable):
3.2.0.GA

How reproducible:
Always

Steps to Reproduce:
1. Navigate to agent's monitoring page.
2. Expand the "Actual Free Memory" metric to reveal its graph.
3. Select the "Summary" tab.
4. Click on the "Actual Free Memory" metric in the "Resource: Measurements" portlet.

Actual results:
Metric Chart: Actual Free Memory is displayed but contains no metric graph.

Expected results:
Metric Chart: Actual Free Memory is displayed and includes a metric graph.

Additional info:
If you collapse the metric on the monitoring page, and reload the chart, the graph will be displayed.

Comment 1 Larry O'Leary 2013-12-09 22:23:33 UTC
Created attachment 834563 [details]
Screen-shot showing missing graph on metric chart

Comment 2 Larry O'Leary 2013-12-09 22:27:41 UTC
Created attachment 834564 [details]
Screen-shot showing missing graph on metric chart

Comment 5 Mike Thompson 2014-02-11 02:52:05 UTC
Created a unique chart naming identifier applicable to the summary portlet charts so the names wouldn't clash.

Committed to master:

commit dfa8a1bb8d80b033282e2c7f4856b62b434330b1
Author: Mike Thompson <mithomps>
Date:   Mon Feb 10 18:45:34 2014 -0800

Comment 6 Mike Thompson 2014-02-11 02:53:49 UTC
@jkremser: can you check and move to release branch?

Comment 7 Jirka Kremser 2014-02-11 12:19:30 UTC
lgtm

branch:  release/jon3.2.x
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=25c2fc47d
time:    2014-02-11 13:12:37 +0100
commit:  25c2fc47d7bc33499dd2bbb0d7fa1fee2efa96c7
author:  Mike Thompson - mithomps
message: [BZ 1039757] Metric graph is missing from summary portlet chart if it
         has been opened on monitoring page.  Created a unique chart
         naming identifier applicable to the summary portlet charts only
         so the names wouldn't clash.
    
    (cherry picked from commit dfa8a1bb8d80b033282e2c7f4856b62b434330b1)
    Signed-off-by: Jirka Kremser <jkremser>
    
Conflicts:
*modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/common/graph/MetricGraphData.java  *modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/common/graph/graphtype/StackedBarMetricGraphImpl.java
*modules/enterprise/gui/coregui/src/main/webapp/js/rhq-4.9.0.js

Comment 8 Mike Thompson 2014-02-11 22:04:15 UTC
There were a couple files that were not merged correctly release/jon3.2.x. I have reverted the previous commit:

commit ceed4c86f3a1dd56e8b13f612fadf3a869dcf773
Author: Mike Thompson <mithomps>
Date:   Tue Feb 11 10:14:25 2014 -0800

    Revert from bad merge: "[BZ 1039757] Metric graph is missing from summary portlet chart if it has been opened on monitoring page."

    This reverts commit 25c2fc47d7bc33499dd2bbb0d7fa1fee2efa96c7.


I re-picked the commit and manually did the merges; double checking the GUI.


commit 7acb11e6155eef410c3658e4b0d0f5f85ad90e5e
Author: Mike Thompson <mithomps>
Date:   Mon Feb 10 18:45:34 2014 -0800

    [BZ 1039757] Fixed release branch merge issues. Metric graph is missing from summary portlet chart if it has been opened on monitoring page.
     Created a unique chart naming identifier applicable to the summary portlet charts only so the names wouldn't clash.

Comment 9 Simeon Pinder 2014-02-18 15:08:30 UTC
Moving to ON_QA as available for testing in the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=336752

Note: the installed version is still JON 3.2.0.GA by design and this represents part of the payload for JON 3.2.1 also known as cumulative patch 1 for 3.2.0.GA.  How this will be delivered to customers is still being discussed.

Comment 10 Mike Foley 2014-02-18 19:49:03 UTC
verified jon 3.2.1 dr1

Comment 11 Mike Foley 2014-05-08 17:43:58 UTC
JON 3.2.1 released week of 5/5/2014


Note You need to log in before you can comment on or make changes to this bug.