Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-wikicloth.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-wikicloth-0.8.0-1.fc21.src.rpm Description: An implementation of the mediawiki markup in Ruby. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6274302
Hi, a small review - package seems good for me. There is just newer version (0.8.1) of package from 2014-01-07 and rpmlint reports bad spelling, but it's because of the name of "Mediawiki". Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gems should require rubygems package Note: Requires: rubygems missing in rubygem-wikicloth-doc See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). [x]: Package contains Requires: ruby(release). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Gem should use %gem_install macro. [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-wikicloth-0.8.0-1.fc20.noarch.rpm rubygem-wikicloth-doc-0.8.0-1.fc20.noarch.rpm rubygem-wikicloth-0.8.0-1.fc20.src.rpm rubygem-wikicloth.noarch: W: spelling-error Summary(en_US) Mediawiki -> Media wiki, Media-wiki, Wikipedia rubygem-wikicloth.noarch: W: spelling-error %description -l en_US mediawiki -> media wiki, media-wiki, Wikipedia rubygem-wikicloth.src: W: spelling-error Summary(en_US) Mediawiki -> Media wiki, Media-wiki, Wikipedia rubygem-wikicloth.src: W: spelling-error %description -l en_US mediawiki -> media wiki, media-wiki, Wikipedia 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-wikicloth-doc rubygem-wikicloth rubygem-wikicloth.noarch: W: spelling-error Summary(en_US) Mediawiki -> Media wiki, Media-wiki, Wikipedia rubygem-wikicloth.noarch: W: spelling-error %description -l en_US mediawiki -> media wiki, media-wiki, Wikipedia 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- rubygem-wikicloth-doc (rpmlib, GLIBC filtered): rubygem-wikicloth rubygem-wikicloth (rpmlib, GLIBC filtered): ruby(release) ruby(rubygems) rubygem(builder) rubygem(expression_parser) Provides -------- rubygem-wikicloth-doc: rubygem-wikicloth-doc rubygem-wikicloth: rubygem(wikicloth) rubygem-wikicloth Source checksums ---------------- https://rubygems.org/gems/wikicloth-0.8.0.gem : CHECKSUM(SHA256) this package : ec1df58200e3803df536d953a464dd365aaeedb11ec4eef1ade9137ebb15e0d1 CHECKSUM(SHA256) upstream package : ec1df58200e3803df536d953a464dd365aaeedb11ec4eef1ade9137ebb15e0d1 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -n rubygem-wikicloth Buildroot used: fedora-20-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
I forgot to mention, that I'm not in packager group yet, so I can't flag and assign it. Sorry for a confusion.
Ok, i reviewed the rpm and it look good. As I agree with the review of Jakub and as I am sponsoring him, I will approve it for him.
Thanks Michael! New Package SCM Request ======================= Package Name: rubygem-wikicloth Short Description: Mediawiki parser Owners: ktdreyer Branches: f20
Git done (by process-git-requests).
Built for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6498208 Closing. Thank you Michael and Jakub.
*** Bug 1071778 has been marked as a duplicate of this bug. ***