Spec URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v1/capnproto-c++.spec SRPM URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v1/capnproto-c++-0.4.0_rc1-1.fc19.src.rpm Description: Cap’n Proto is an insanely fast data interchange format and capability-based RPC system. Think JSON, except binary. Or think Protocol Buffers, except faster. In fact, in benchmarks, Cap’n Proto is INFINITY TIMES faster than Protocol Buffers. Fedora Account System Username: amluto Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6278465 A couple of notes: - This is for capnproto 0.4.0-rc1. The hyphen in the name makes it messy. I don't want to push this out for real until 0.4.0 is released, so the hyphen mess in the spec file can go away. - Cap'n Proto is under pretty heavy development, but the serialization format should be stable, and the tools are usable now.
Spec URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v2/capnproto-c++.spec SRPM URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v2/capnproto-c++-0.4.0-1.fc19.src.rpm As promised, here's a real release version. I also fixed a silly typo in the description and added (new) pkgconfig files from upstream. These packages are missing docs. They're in upstream git but not in the release packages. I'll email upstream.
* A review ticket blocking the FE-NEEDSPONSOR tracker appears on the page http://fedoraproject.org/PackageReviewStatus/NEEDSPONSOR.html * Keep the spec %summary in sync with the bugzilla ticket Summary, so there won't be any confusion when creating the package in Fedora infrastructure (such as pkgdb). * https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description > This is for capnproto 0.4.0-rc1. The hyphen in the name makes it messy. There are versioning guidelines that would move the "rc1" into the Release tag: https://fedoraproject.org/wiki/Packaging:Guidelines#Version_and_Release https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages A 0.4.0-rc1 would have become Version: 0.4.0 Release: 0.1.rc1%{?dist} instead of Version: 0.4.0-rc1 Release: 1%{?dist} That makes it easier (and more convenient) to update from 0.4.0 pre-releases to 0.4.0 final and also to 0.4.0 post-releases without running into trouble with RPM version comparison. > %doc Empty %doc lines are a no-op and should be deleted. > # Make runs tests, and the tests can't find the just-built libraries when > # rpath is suppressed. Adding the .libs directory to LD_LIBRARY_PATH > # lets the tests pass. > LD_LIBRARY_PATH="`/bin/pwd`/.libs" make %{?_smp_mflags} So far so good, but what about the "check" target? It's missing in the Make invocation and would build and run "354 tests from 42 test cases". Not to be confused with gtest's own test-suite. diff -u capnproto-c++.spec.orig capnproto-c++.spec --- capnproto-c++.spec.orig 2013-12-12 21:23:28.000000000 +0100 +++ capnproto-c++.spec 2013-12-24 12:24:05.937240179 +0100 @@ -52,6 +52,10 @@ find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' +%check +LD_LIBRARY_PATH=$(pwd)/.libs:$(pwd)/gtest/lib/.libs make %{?_smp_mflags} check + + %post -p /sbin/ldconfig %postun -p /sbin/ldconfig
Sorry, I'm out of the country and therefore a bit slow, and I forgot to unblock FE-NEEDSPONSOR, since I don't need a sponsor anymore. I'll upload a fixed-up soon. I suspect that there are some other good cleanups I could do, too. FWIW, 0.4.0 is out now, so I'll switch to that. I'm also tempted to rename the package to just capnproto (instead of capnproto-c++). The upstream tarball is capnproto-c++, but the tools built (capnp and capnpc) aren't specific to C++ users.
Spec URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v3/capnproto.spec SRPM URL: http://web.mit.edu/luto/www/fedora/capnproto_rpm_v3/capnproto-0.4.0-3.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6342862 A couple of notes: - Docs are missing from the release package. I pinged upstream. I could package the docs from git, but that seems messy if I can avoid it. - There are no manpages. I don't think they've been written. - capnproto bundles gtest and some patches to gtest. I don't think that any of the bundled gtest ends up in the binary rpms, though (except for -debuginfo).
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117
@Andy: Are you still interested continuing this review to package capnproto? I've packaged it in a COPR[0] and I'd like to bring it into Fedora. If you're not interested in continuing this review (at which point I'd file a new review request), I'd be happy to have you as a co-maintainer of the package, if you're interested in that. [0]: https://copr.fedorainfracloud.org/coprs/ngompa/capnproto/
Your version is probably much nicer than mine -- this one is seriously out of date. I could update it and let you review it, or I could cancel this and you could cc me on a new review request. Either way would be fine with me.
Why don't we go ahead and go with the latter? I'll create a new review request and CC you on it.
Superseded by #1328968 *** This bug has been marked as a duplicate of bug 1328968 ***