Description of problem:
When running fedora-review with the EPEL5 flag defined, the review report correctly does not report issues about the presence of a BuildRoot tag. However the line in the report says:
[x]: Buildroot is not present
which is confusing, because there is a BuildRoot tag present. The proper output should be something like:
[x]: EPEL5 requires explicit Buildroot tag
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. fedora-review -D EPEL5 ....
[x]: Buildroot is not present
[x]: EPEL5 requires explicit BuildRoot tag
Proposed fix committed as commit 178b7b7 upstream (release-0.5.1 branch)
fedora-review-0.5.1-1.fc18 has been submitted as an update for Fedora 18.
fedora-review-0.5.1-1.el6 has been submitted as an update for Fedora EPEL 6.
fedora-review-0.5.1-1.fc19 has been submitted as an update for Fedora 19.
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing fedora-review-0.5.1-1.fc20'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
Created attachment 837229 [details]
Fixes the issue properly
The output is still the same in version 0.5.1-1.fc19.
If the check of the EPEL5 flag is moved away form the __init__ it works better - patch attached.
fedora-review-0.5.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
Reopening since I forgot to remove this bug from fedora update
fedora-review-0.5.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
The bug was autoclosed again...
This message is a notice that Fedora 19 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 19. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 19 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Fixed in 0.5.2.