Bug 1045032 - iproute2: "ip -o link" doesn't show devices entries in a single line when reporting SR-IOV devs.
Summary: iproute2: "ip -o link" doesn't show devices entries in a single line when rep...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: iproute
Version: 6.5
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Jaroslav Aster
URL:
Whiteboard:
Depends On:
Blocks: 1172231 1275424
TreeView+ depends on / blocked
 
Reported: 2013-12-19 13:43 UTC by Antoni Segura Puimedon
Modified: 2016-05-11 00:18 UTC (History)
5 users (show)

Fixed In Version: iproute-2.6.32-47.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1272405 1272406 (view as bug list)
Environment:
Last Closed: 2016-05-11 00:18:40 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:0895 0 normal SHIPPED_LIVE iproute bug fix and enhancement update 2016-05-10 22:50:11 UTC

Description Antoni Segura Puimedon 2013-12-19 13:43:11 UTC 
Description of problem:In the description of the '-o' switch for iproute's 'ip' tool, it says that the entries should be kept in one line escaping the end of lines with '\'. However, when a machine has an intel's sr-iov device configured with several virtual functions, the contract is broken (breaking machine parse-ability).


Version-Release number of selected component (if applicable):


How reproducible: 100%




Steps to Reproduce:
1. Configure an SR-IOV capable machine with several vfs (this report is with devices using the modules igb and igbvf for the VFs).
2. ip -o link show

Actual results:

    2: p1p1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 90:e2:ba:04:29:88 brd ff:ff:ff:ff:ff:ff
        vf 0 MAC d2:e9:dd:53:3d:a5
        vf 1 MAC aa:f7:de:38:1c:f9
        vf 2 MAC 22:44:45:db:ff:8a
        vf 3 MAC a2:59:8d:b9:17:30
        vf 4 MAC 4a:d8:39:86:38:d5
        vf 5 MAC 6e:4e:cc:21:74:7f
        vf 6 MAC d6:75:14:15:1d:8b
    3: p1p2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 90:e2:ba:04:29:89 brd ff:ff:ff:ff:ff:ff
        vf 0 MAC 66:0c:f8:af:e4:bb
        vf 1 MAC 2e:4e:a5:99:c1:33
        vf 2 MAC 46:ff:0f:cc:8e:a5
        vf 3 MAC e6:b6:67:e6:54:7d
        vf 4 MAC 16:fb:b0:a2:c7:55
        vf 5 MAC 16:58:73:bd:15:8f
        vf 6 MAC ce:d1:fe:b9:5d:cb
    4: em1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000\    link/ether d0:67:e5:f0:82:44 brd ff:ff:ff:ff:ff:ff
    5: em2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether d0:67:e5:f0:82:45 brd ff:ff:ff:ff:ff:ff
    6: p1p1_0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 42:b1:fd:72:2f:59 brd ff:ff:ff:ff:ff:ff
    7: p1p1_1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 4e:2b:eb:99:fe:c2 brd ff:ff:ff:ff:ff:ff
    8: p1p1_2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether f2:53:2c:4e:1e:96 brd ff:ff:ff:ff:ff:ff
    9: p1p1_3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether e2:93:d8:f6:2a:b5 brd ff:ff:ff:ff:ff:ff
    10: p1p1_4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 9a:99:5b:3d:3c:4f brd ff:ff:ff:ff:ff:ff
    11: p1p1_5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 0e:eb:7f:df:bc:44 brd ff:ff:ff:ff:ff:ff
    12: p1p1_6: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether ae:e5:41:ae:6f:e2 brd ff:ff:ff:ff:ff:ff
    13: p1p2_0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 6a:23:4c:f9:fb:3c brd ff:ff:ff:ff:ff:ff
    14: p1p2_1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether b6:ea:d0:b7:6d:b7 brd ff:ff:ff:ff:ff:ff
    15: p1p2_2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 52:d1:76:44:44:50 brd ff:ff:ff:ff:ff:ff
    16: p1p2_3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 7a:fa:9f:53:f9:f5 brd ff:ff:ff:ff:ff:ff
    17: p1p2_4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 8a:5b:2e:50:91:1d brd ff:ff:ff:ff:ff:ff
    18: p1p2_5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 86:61:6d:23:a3:25 brd ff:ff:ff:ff:ff:ff
    19: p1p2_6: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN qlen 1000\    link/ether ae:77:9c:8a:68:2a brd ff:ff:ff:ff:ff:ff
    20: rhevm: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN \    link/ether d0:67:e5:f0:82:44 brd ff:ff:ff:ff:ff:ff
    21: virbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN \    link/ether 52:54:00:b3:64:0f brd ff:ff:ff:ff:ff:ff
    22: virbr0-nic: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 500\    link/ether 52:54:00:b3:64:0f brd ff:ff:ff:ff:ff:ff
    25: ;vdsmdummy;: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN \    link/ether 32:d5:74:10:a8:28 brd ff:ff:ff:ff:ff:ff
    26: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    27: bond4: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    28: bond1: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    29: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    30: bond3: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff



Expected results:

    2: p1p1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 90:e2:ba:04:29:88 brd ff:ff:ff:ff:ff:ff \    vf 0 MAC d2:e9:dd:53:3d:a5 \    vf 1 MAC aa:f7:de:38:1c:f9 \    vf 2 MAC 22:44:45:db:ff:8a \    vf 3 MAC a2:59:8d:b9:17:30 \    vf 4 MAC 4a:d8:39:86:38:d5 \    vf 5 MAC 6e:4e:cc:21:74:7f \    vf 6 MAC d6:75:14:15:1d:8b
    3: p1p2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 90:e2:ba:04:29:89 brd ff:ff:ff:ff:ff:ff \    vf 0 MAC 66:0c:f8:af:e4:bb \    vf 1 MAC 2e:4e:a5:99:c1:33 \    vf 2 MAC 46:ff:0f:cc:8e:a5 \    vf 3 MAC e6:b6:67:e6:54:7d \    vf 4 MAC 16:fb:b0:a2:c7:55 \    vf 5 MAC 16:58:73:bd:15:8f \    vf 6 MAC ce:d1:fe:b9:5d:cb
    4: em1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000\    link/ether d0:67:e5:f0:82:44 brd ff:ff:ff:ff:ff:ff
    5: em2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether d0:67:e5:f0:82:45 brd ff:ff:ff:ff:ff:ff
    6: p1p1_0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 42:b1:fd:72:2f:59 brd ff:ff:ff:ff:ff:ff
    7: p1p1_1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 4e:2b:eb:99:fe:c2 brd ff:ff:ff:ff:ff:ff
    8: p1p1_2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether f2:53:2c:4e:1e:96 brd ff:ff:ff:ff:ff:ff
    9: p1p1_3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether e2:93:d8:f6:2a:b5 brd ff:ff:ff:ff:ff:ff
    10: p1p1_4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 9a:99:5b:3d:3c:4f brd ff:ff:ff:ff:ff:ff
    11: p1p1_5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 0e:eb:7f:df:bc:44 brd ff:ff:ff:ff:ff:ff
    12: p1p1_6: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether ae:e5:41:ae:6f:e2 brd ff:ff:ff:ff:ff:ff
    13: p1p2_0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 6a:23:4c:f9:fb:3c brd ff:ff:ff:ff:ff:ff
    14: p1p2_1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether b6:ea:d0:b7:6d:b7 brd ff:ff:ff:ff:ff:ff
    15: p1p2_2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 52:d1:76:44:44:50 brd ff:ff:ff:ff:ff:ff
    16: p1p2_3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 7a:fa:9f:53:f9:f5 brd ff:ff:ff:ff:ff:ff
    17: p1p2_4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 8a:5b:2e:50:91:1d brd ff:ff:ff:ff:ff:ff
    18: p1p2_5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000\    link/ether 86:61:6d:23:a3:25 brd ff:ff:ff:ff:ff:ff
    19: p1p2_6: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN qlen 1000\    link/ether ae:77:9c:8a:68:2a brd ff:ff:ff:ff:ff:ff
    20: rhevm: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN \    link/ether d0:67:e5:f0:82:44 brd ff:ff:ff:ff:ff:ff
    21: virbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN \    link/ether 52:54:00:b3:64:0f brd ff:ff:ff:ff:ff:ff
    22: virbr0-nic: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 500\    link/ether 52:54:00:b3:64:0f brd ff:ff:ff:ff:ff:ff
    25: ;vdsmdummy;: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN \    link/ether 32:d5:74:10:a8:28 brd ff:ff:ff:ff:ff:ff
    26: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    27: bond4: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    28: bond1: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    29: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    30: bond3: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN \    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff

Additional info:
I used this SR-IOV capable devices:
01:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
01:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
Comment 2 Antoni Segura Puimedon 2013-12-19 13:47:19 UTC 
I have not checked Fedora nor RHEL-7.0 Beta, but they are likely to have the same issue, it should be checked and cloned if it is the case.
Comment 3 Dan Kenigsberg 2013-12-19 16:44:22 UTC 
Wouldn't it be even nicer if each vf reported its parent pf?

It seems that currently we must depend on the iface naming convention to do this mapping, or go /sys/class.
Comment 4 Antoni Segura Puimedon 2013-12-19 16:55:35 UTC 
@Danken: maybe something like "physfn eth1".
Comment 6 Petr Šabata 2014-01-21 10:09:48 UTC 
(In reply to Dan Kenigsberg from comment #3)
> Wouldn't it be even nicer if each vf reported its parent pf?

That's a good idea, better than putting all the vf on the same line with the parent interface.
Comment 11 Phil Sutter 2015-10-16 10:39:59 UTC 
Wile I agree with the opinion that VF interfaces should list which physical one they belong to, I don't think this belongs to this ticket. A quick research shows that the kernel exports a list of virtual functions for the physical interface, and iproute reflects just that. So changing the way things are presented might need some preliminary kernel work. I'll clone this ticket into an RFE one to keep me reminded to investigate further. This ticket is about the bug in output formatting, which is indeed present and valid. Patch fixing this sent upstream:

http://marc.info/?l=linux-netdev&m=144499191904348&w=2
Comment 18 errata-xmlrpc 2016-05-11 00:18:40 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0895.html
Note You need to log in before you can comment on or make changes to this bug.