Spec URL: http://slinabery.fedorapeople.org/python-jsonpath-rw.spec SRPM URL: http://slinabery.fedorapeople.org/python-jsonpath-rw-1.2.1-1.fc18.src.rpm Description: extended implementation of JSONPath for Python Fedora Account System Username: slinaber
builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=6316938
Please hold on this package review. Upstream just informed me that a new release is available which addresses https://github.com/kennknowles/python-jsonpath-rw/issues/11 I will prepare a new SRPM immediately.
SpecURL (updated): http://slinabery.fedorapeople.org/python-jsonpath-rw.spec SRPM URL: http://slinabery.fedorapeople.org/python-jsonpath-rw-1.2.3-1.fc18.src.rpm koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6317352
1. Source0: https://github.com/kennknowles/python-jsonpath-rw/archive/%version.tar.gz -> Source0: https://github.com/kennknowles/python-jsonpath-rw/archive/%{version}.tar.gz 2. python-devel -> python2-devel %{python_sitelib} -> %{python2_sitelib} 3. Remove: Provides: python-jsonpath-rw = %{version}-%{release} 4. python3 package is incorrect packaged, see an example of mine: http://cicku.me/python-pygit2.spec You can see that currect spec you provide is questionable: Processing files: python-jsonpath-rw-1.2.3-1.fc21.noarch Provides: python-jsonpath-rw = 1.2.3-1.fc21 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: python(abi) = 2.7 python(abi) = 3.3 Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/python-jsonpath-rw-1.2.3-1.fc21.noarch warning: Could not canonicalize hostname: buildvm-26.phx2.fedoraproject.org Wrote: /builddir/build/RPMS/python-jsonpath-rw-1.2.3-1.fc21.noarch.rpm 5. Remove rm -rf $RPM_BUILD_ROOT, we don't need this even on EPEL6. 6. %{python3_sitelib} -> %{python3_sitelib}/*, because this package shouldn't own this directory.
Christopher: about your remark number 5 in #c4: According to 'rawhide report: 20131228 changes' OpenStack Ceilometer needs python-jsonpath-rw and OpenStack Ceilometer is also built for EL6: http://koji.fedoraproject.org/koji/packageinfo?packageID=15819 So python-jsonpath-rw is needed for EPEL6.
OK, please provide me an updated SRPM/SPEC so I can review them again. And don't forget to fix issues.
(In reply to Patrick Laimbock from comment #5) > Christopher: about your remark number 5 in #c4: > > According to 'rawhide report: 20131228 changes' OpenStack Ceilometer needs > python-jsonpath-rw and OpenStack Ceilometer is also built for EL6: > > http://koji.fedoraproject.org/koji/packageinfo?packageID=15819 > > So python-jsonpath-rw is needed for EPEL6. Uh, I forgot to reply to this. I mean this line: rm -rf $RPM_BUILD_ROOT, is not needed even on EPEL6; Not this package.
Apols for excessive holiday lag. Updated with fixes: http://slinabery.fedorapeople.org/python-jsonpath-rw.spec http://slinabery.fedorapeople.org/python-jsonpath-rw-1.2.3-1.fc18.src.rpm koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6349202 summary (git diff) of changes to spec since last review (hth): http://slinabery.fedorapeople.org/python-jsonpath-rw.spec.diff thanks!
No problem, happy new yarr! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/__init__.py python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/jsonpath.py python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/lexer.py python-jsonpath-rw-1.2.3/%{py3dir}/jsonpath_rw/parser.py python-jsonpath-rw-1.2.3/%{py3dir}/setup.py python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_jsonpath.py python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_lexer.py python-jsonpath-rw-1.2.3/%{py3dir}/tests/test_parser.py python-jsonpath-rw-1.2.3/jsonpath_rw/__init__.py python-jsonpath-rw-1.2.3/jsonpath_rw/jsonpath.py python-jsonpath-rw-1.2.3/jsonpath_rw/lexer.py python-jsonpath-rw-1.2.3/jsonpath_rw/parser.py python-jsonpath-rw-1.2.3/setup.py python-jsonpath-rw-1.2.3/tests/test_jsonpath.py python-jsonpath-rw-1.2.3/tests/test_lexer.py python-jsonpath-rw-1.2.3/tests/test_parser.py ---> Tell upstream. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -jsonpath-rw [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python-jsonpath-rw-1.2.3-1.fc21.noarch.rpm python3-jsonpath-rw-1.2.3-1.fc21.noarch.rpm python-jsonpath-rw-1.2.3-1.fc21.src.rpm python-jsonpath-rw.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 8) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-jsonpath-rw python-jsonpath-rw 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python3-jsonpath-rw (rpmlib, GLIBC filtered): python(abi) python3-decorator python3-ply python3-six python-jsonpath-rw (rpmlib, GLIBC filtered): python(abi) python-decorator python-ply python-six Provides -------- python3-jsonpath-rw: python3-jsonpath-rw python-jsonpath-rw: python-jsonpath-rw Source checksums ---------------- https://github.com/kennknowles/python-jsonpath-rw/archive/1.2.3.tar.gz : CHECKSUM(SHA256) this package : 044e5069631c159eea142d89da6e1e0e41adc1527741ff573677c20c4f67caef CHECKSUM(SHA256) upstream package : 044e5069631c159eea142d89da6e1e0e41adc1527741ff573677c20c4f67caef Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn python-jsonpath-rw-1.2.3-1.fc18.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Python, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG ---------------- Nice work! PACKAGE APPROVED.
New Package SCM Request ======================= Package Name: python-jsonpath-rw Short Description: Extended implementation of JSONPath Owners: slinabery Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
python-jsonpath-rw-1.2.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-jsonpath-rw-1.2.3-2.fc20
python-jsonpath-rw-1.2.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-jsonpath-rw-1.2.3-2.el6
python-jsonpath-rw-1.2.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-jsonpath-rw-1.2.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-jsonpath-rw-1.2.3-2.fc19 has been pushed to the Fedora 19 stable repository.
python-jsonpath-rw-1.2.3-2.fc20 has been pushed to the Fedora 20 stable repository.