Bug 1045744 - RFE: add ability to upload source rpms to build
Summary: RFE: add ability to upload source rpms to build
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Copr
Classification: Community
Component: cli
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact:
URL:
Whiteboard:
: 1141881 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-21 17:14 UTC by Ville Skyttä
Modified: 2015-08-11 18:48 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-11 13:52:37 UTC
Embargoed:


Attachments (Terms of Use)

Description Ville Skyttä 2013-12-21 17:14:32 UTC
Having to host source rpms somewhere outside of copr is an annoyance, in fact annoying enough for me to not use it yet. The ability to upload srpms to build, both from cli as well as the web interface would be a big improvement.

Comment 1 Miroslav Suchý 2013-12-26 12:02:30 UTC
This is on my wishlist as well. However this will require to have bigger storage. And having this implemented in fronted.
Especially the storage will need some time. My ETA is at least 6 months.

Comment 2 Ville Skyttä 2013-12-29 15:23:54 UTC
(In reply to Miroslav Suchý from comment #1)
> However this will require to have bigger storage.

Hm, I don't understand how this would need any more storage than what is currently required. Retrieving a source rpm from a URL or uploading it takes the same (probably temporary) space. And source rpms resulting from builds seem to be hosted in repositories already, and uploading/downloading-from-URL shouldn't make a difference there anyway. Did I miss something?

Comment 3 Miroslav Suchý 2013-12-30 11:01:02 UTC
Current design is that: frontend does not touch neither src.rpm nor binary rpm at all. And neither backend touch src.rpm. The URL is passed directly to builder. Which download it itself. Builder is VM which is terminated right after build. Rebuilded binary rpm and src.rpm (which is different from original src.rpm) are exctracted by backend right before terminating that VM.

Hmm, but you are right we can upload src.rpm to fronted only temporary and remove it after the build finish (no matter with what result).
That should work.

Comment 4 Ville Skyttä 2013-12-31 12:25:29 UTC
Thanks for the explanation and in advance for taking time to look into this.

Comment 5 Miroslav Suchý 2014-09-16 06:47:19 UTC
*** Bug 1141881 has been marked as a duplicate of this bug. ***

Comment 6 Michael J Gruber 2015-01-13 12:43:26 UTC
Note that anyone with an FAS account can use their webspace on fedorapeople.org for srpm uploads. Say:

scp ${rpm} ${user}.fedoropeople.org:public_html/copr/

Then point copr (cli or web) to ${user}.fedorapeople.org:copr/${rpm}

All with the same FAS account.

bug 1118968 would help with specifying a default location.

Comment 7 Ville Skyttä 2015-02-18 21:18:19 UTC
(In reply to Michael J Gruber from comment #6)
> Note that anyone with an FAS account can use their webspace on
> fedorapeople.org for srpm uploads. Say:
> 
> scp ${rpm} ${user}.fedoropeople.org:public_html/copr/
> 
> Then point copr (cli or web) to ${user}.fedorapeople.org:copr/${rpm}

Sure. And then "ssh ${user}.fedorapeople.org rm public_html/copr/${rpm}". The point of this bug report is that at least for me and I guess for many others, these extra steps are a complete waste of time. Bug 1118968 doesn't help that at all.

Comment 8 Jakub Kadlčík 2015-08-10 10:23:13 UTC
Frontend modified in: 852775f
CLI modified in: ccd1680, adf07fe

---

Usage will be:

copr-cli build user/project /tmp/tito/foo.src.rpm

agreed Miroslav?

Comment 9 Miroslav Suchý 2015-08-11 13:52:37 UTC
This fix is deployed in production on copr.fedoraproject.org

Comment 10 Ville Skyttä 2015-08-11 15:06:43 UTC
Sweet, will try it out soon!

Comment 11 Severin Gehwolf 2015-08-11 17:14:53 UTC
(In reply to Miroslav Suchý from comment #9)
> This fix is deployed in production on copr.fedoraproject.org

Which copr-cli version supports this? Is this web UI only?

Comment 12 Miroslav Suchý 2015-08-11 18:48:13 UTC
(In reply to Severin Gehwolf from comment #11)
> Which copr-cli version supports this? Is this web UI only?

python-copr-1.58-1 -- should be in testing soon. I just submitted it there today.


Note You need to log in before you can comment on or make changes to this bug.