Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1045826 - Review Request: perl-Image-Dot - Create 1x1 pixel image files in pure perl
Summary: Review Request: perl-Image-Dot - Create 1x1 pixel image files in pure perl
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2013-12-22 10:42 UTC by Yanko Kaneti
Modified: 2014-01-18 18:21 UTC (History)
2 users (show)

Fixed In Version: perl-Image-Dot-1.1-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-01-18 18:21:07 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Yanko Kaneti 2013-12-22 10:42:06 UTC
Spec URL: http://declera.com/~yaneti/perl-Image-Dot/perl-Image-Dot.spec
SRPM URL: http://declera.com/~yaneti/perl-Image-Dot/perl-Image-Dot-1.1-1.fc21.src.rpm
This package provides 1x1 pixel PNG images of a certain RGB color (also
with transparency) without relying on any external modules like GD, libpng
or Compress::Zlib. These pixel dots can be useful in a pure-perl HTTP
server to be able to create colored dots on-the-fly, e.g. for formatting or
drawing purposes.
Fedora Account System Username: yaneti

Comment 1 Christopher Meng 2013-12-27 12:14:43 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in:

Unknown or generated

[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/perl5/vendor_perl/Image(perl-Image-Xbm, perl-Image-Info, perl-
     Image-Base, perl-Image-Xpm)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: perl-Image-Dot-1.1-1.fc21.noarch.rpm
perl-Image-Dot.noarch: W: spelling-error %description -l en_US libpng -> sibling
perl-Image-Dot.noarch: W: spelling-error %description -l en_US Zlib -> Zib, Lib, Glib
perl-Image-Dot.src: W: spelling-error %description -l en_US libpng -> sibling
perl-Image-Dot.src: W: spelling-error %description -l en_US Zlib -> Zib, Lib, Glib
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages)
# rpmlint perl-Image-Dot
perl-Image-Dot.noarch: W: spelling-error %description -l en_US libpng -> sibling
perl-Image-Dot.noarch: W: spelling-error %description -l en_US Zlib -> Zib, Lib, Glib
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

perl-Image-Dot (rpmlib, GLIBC filtered):


Source checksums
http://www.cpan.org/authors/id/R/RG/RGIERSIG/Image-Dot-1.1.tar.gz :
  CHECKSUM(SHA256) this package     : 3b6a036e00b2d1146434f1b99fb954e3f4d4cfc0a06c6761e4f554f40f46c584
  CHECKSUM(SHA256) upstream package : 3b6a036e00b2d1146434f1b99fb954e3f4d4cfc0a06c6761e4f554f40f46c584

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn perl-Image-Dot-1.1-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Perl
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby

1. Remove this line:

find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;

2. Add Requires: of these:

Requires:    perl(strict)
Requires:    perl(vars)
Requires:    perl(warnings)

I'd like to a new spec of changes from you, then I will set +.


Comment 2 Christopher Meng 2013-12-27 12:40:01 UTC
Sorry, a mistake:

> 2. Add Requires: of these:

should be:

2. Add BuildRequires: of these:

Comment 3 Yanko Kaneti 2013-12-27 14:01:23 UTC
Thanks for the review.

- Minor changes brought up in review #1045826

Spec URL: http://declera.com/~yaneti/perl-Image-Dot/perl-Image-Dot.spec
SRPM URL: http://declera.com/~yaneti/perl-Image-Dot/perl-Image-Dot-1.1-2.fc21.src.rpm

Comment 4 Yanko Kaneti 2013-12-27 17:39:51 UTC
New Package SCM Request
Package Name: perl-Image-Dot
Short Description: Create 1x1 pixel image files in pure perl
Owners: yaneti
Branches: f20 el6 el7
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-01-02 12:45:58 UTC
Git done (by process-git-requests).

No el7 yet.

Comment 6 Fedora Update System 2014-01-02 13:31:55 UTC
perl-Image-Dot-1.1-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 7 Fedora Update System 2014-01-02 13:32:51 UTC
perl-Image-Dot-1.1-2.fc20 has been submitted as an update for Fedora 20.

Comment 8 Fedora Update System 2014-01-02 23:13:29 UTC
perl-Image-Dot-1.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 9 Fedora Update System 2014-01-11 08:46:27 UTC
perl-Image-Dot-1.1-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2014-01-18 18:21:07 UTC
perl-Image-Dot-1.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.