Spec URL: http://scientific.zcu.cz/fedora/glite-lb-state-machine-2.0.7-1/glite-lb-state-machine.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-state-machine-2.0.7-1/glite-lb-state-machine-2.0.7-1.fc21.src.rpm Description: glite-lb-state-machine is the gLite L&B job state machine -- server core processing L&B events to produce job state presented to the user. This package contains the state machine library (linked by server) and dynamic plugin (used by other tools and Job Provenance). Fedora Account System Username: valtri Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6333355
Will review soon.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= [x] Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages [?] ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in glite-lb-state-machine-plugins See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries I assume these libs are private, right? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck: Apache (v2.0) ------------- glite-lb-state-machine-2.0.7/interface/intjobstat.h glite-lb-state-machine-2.0.7/interface/process_event.h glite-lb-state-machine-2.0.7/interface/seqcode_aux.h glite-lb-state-machine-2.0.7/src/lb_plugin.c glite-lb-state-machine-2.0.7/src/process_event.c glite-lb-state-machine-2.0.7/src/process_event_condor.c glite-lb-state-machine-2.0.7/src/process_event_cream.c glite-lb-state-machine-2.0.7/src/process_event_file_transfer.c glite-lb-state-machine-2.0.7/src/process_event_file_transfer_collection.c glite-lb-state-machine-2.0.7/src/process_event_pbs.c glite-lb-state-machine-2.0.7/src/process_event_virtual_machine.c glite-lb-state-machine-2.0.7/src/seqcode_aux.c Unknown or generated -------------------- glite-lb-state-machine-2.0.7/interface/intjobstat_supp.h glite-lb-state-machine-2.0.7/src/intjobstat_supp.c glite-lb-state-machine-2.0.7/src/job_attrs.xsl glite-lb-state-machine-2.0.7/src/job_attrs2.xsl glite-lb-state-machine-2.0.7/src/jpis_config.xsl ---> Since you are the upstream maintainer, please add license header later(not a blocker of this review.) [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in glite-lb- state-machine-plugins [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: glite-lb-state-machine-2.0.7-1.fc21.i686.rpm glite-lb-state-machine-devel-2.0.7-1.fc21.i686.rpm glite-lb-state-machine-plugins-2.0.7-1.fc21.i686.rpm glite-lb-state-machine-2.0.7-1.fc21.src.rpm glite-lb-state-machine.i686: W: summary-not-capitalized C gLite Logging and Bookkeeping state machine glite-lb-state-machine-devel.i686: W: no-documentation glite-lb-state-machine-plugins.i686: W: no-documentation glite-lb-state-machine.src: W: summary-not-capitalized C gLite Logging and Bookkeeping state machine 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint glite-lb-state-machine-plugins glite-lb-state-machine glite-lb-state-machine-devel glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_append_tags glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_attrval_free glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_pread glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_clear_error glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_stack_error -----> Are they caused by unreleased dependencies? [rpmaker@fab Desktop]$ ldd -r ~/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so linux-gate.so.1 => (0xb7774000) libglite_lb_common.so.16 => not found libglite_security_gss.so.9 => not found libglite_jobid.so.2 => not found libc.so.6 => /lib/libc.so.6 (0xb756b000) /lib/ld-linux.so.2 (0xb7775000) undefined symbol: edg_wll_EventToString (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: glite_jobid_parse (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_gss_equal_subj (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_InitStatus (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_CreamStatToString (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: glite_jobid_dup (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_StringToStat (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_StatToString (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: glite_jobid_free (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_CopyTagList (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: glite_jobid_unparse (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_FreeStatus (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_StringToCreamStat (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: trio_asprintf (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) undefined symbol: edg_wll_SourceToString (/home/rpmaker/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so) glite-lb-state-machine-plugins.i686: W: no-documentation glite-lb-state-machine.i686: W: summary-not-capitalized C gLite Logging and Bookkeeping state machine glite-lb-state-machine-devel.i686: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 8 warnings. # echo 'rpmlint-done:' Requires -------- glite-lb-state-machine-plugins (rpmlib, GLIBC filtered): libc.so.6 libglite_lb_common.so.16 rtld(GNU_HASH) glite-lb-state-machine (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6 libglite_jobid.so.2 libglite_lb_common.so.16 libglite_security_gss.so.9 rtld(GNU_HASH) glite-lb-state-machine-devel (rpmlib, GLIBC filtered): glite-lb-common-devel(x86-32) glite-lb-state-machine(x86-32) libglite_lb_statemachine.so.6 Provides -------- glite-lb-state-machine-plugins: glite-lb-state-machine-plugins glite-lb-state-machine-plugins(x86-32) glite-lb-state-machine: glite-lb-state-machine glite-lb-state-machine(x86-32) libglite_lb_statemachine.so.6 glite-lb-state-machine-devel: glite-lb-state-machine-devel glite-lb-state-machine-devel(x86-32) Unversioned so-files -------------------- glite-lb-state-machine-plugins: /usr/lib/glite_lb_plugin.so Source checksums ---------------- http://scientific.zcu.cz/emi/emi.lb.state-machine/glite-lb-state-machine-2.0.7.tar.gz : CHECKSUM(SHA256) this package : 15ddd0feb4d98baf833df3dca3538c62abfafde397a604ef02931f46392a53db CHECKSUM(SHA256) upstream package : 15ddd0feb4d98baf833df3dca3538c62abfafde397a604ef02931f46392a53db Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn glite-lb-state-machine-2.0.7-1.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG ---------------- Answer these questions above and then I will approve it.
(In reply to Christopher Meng from comment #2) > > Issues: > ======= > [x] Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > [?] ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in glite-lb-state-machine-plugins > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > > I assume these libs are private, right? > Basically yes. One library is "normal" (the glite-lb-state-machine package) and the other is a plugin (private library loaded at runtime, the glite-lb-state-machine-plugins package). > > Unknown or generated > -------------------- > glite-lb-state-machine-2.0.7/interface/intjobstat_supp.h > glite-lb-state-machine-2.0.7/src/intjobstat_supp.c > glite-lb-state-machine-2.0.7/src/job_attrs.xsl > glite-lb-state-machine-2.0.7/src/job_attrs2.xsl > glite-lb-state-machine-2.0.7/src/jpis_config.xsl > > ---> Since you are the upstream maintainer, please add license header > later(not a blocker of this review.) > OK. > > Rpmlint (installed packages) > ---------------------------- > # rpmlint glite-lb-state-machine-plugins glite-lb-state-machine > glite-lb-state-machine-devel > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_append_tags > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_attrval_free > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_pread > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_clear_error > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_stack_error > > -----> Are they caused by unreleased dependencies? > Yes, these symbols are provided by the code using the plugin. It is used in glite-lb-utils package for example (not yet submitted for review). > [rpmaker@fab Desktop]$ ldd -r > ~/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so > linux-gate.so.1 => (0xb7774000) > libglite_lb_common.so.16 => not found > libglite_security_gss.so.9 => not found > libglite_jobid.so.2 => not found > libc.so.6 => /lib/libc.so.6 (0xb756b000) > /lib/ld-linux.so.2 (0xb7775000) The missing libraries looks wrong, but I guess the ldd were just called on extracted library here and rpms were not installed. Thanks for the review!
New Package SCM Request ======================= Package Name: glite-lb-state-machine Short Description: gLite Logging and Bookkeeping state machine Owners: valtri Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
glite-lb-state-machine-2.0.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/glite-lb-state-machine-2.0.7-1.fc20
glite-lb-state-machine-2.0.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glite-lb-state-machine-2.0.7-1.fc19
glite-lb-state-machine-2.0.7-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glite-lb-state-machine-2.0.7-1.el6
glite-lb-state-machine-2.0.7-1.fc20 has been pushed to the Fedora 20 testing repository.
glite-lb-state-machine-2.0.7-1.fc19 has been pushed to the Fedora 19 stable repository.
glite-lb-state-machine-2.0.7-1.fc20 has been pushed to the Fedora 20 stable repository.
glite-lb-state-machine-2.0.7-1.el6 has been pushed to the Fedora EPEL 6 stable repository.