Bug 1046584 - Review Request: libzhuyin - Library to deal with zhuyin
Summary: Review Request: libzhuyin - Library to deal with zhuyin
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-26 08:25 UTC by Peng Wu
Modified: 2013-12-28 02:15 UTC (History)
1 user (show)

Fixed In Version: libzhuyin-0.9.93-1.fc19
Clone Of:
Environment:
Last Closed: 2013-12-28 02:14:27 UTC
Type: ---
Embargoed:
panemade: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Peng Wu 2013-12-26 08:25:16 UTC
Spec URL: http://pwu.fedorapeople.org/ibus/libzhuyin/libzhuyin.spec
SRPM URL: http://pwu.fedorapeople.org/ibus/libzhuyin/libzhuyin-0.9.93-1.fc20.src.rpm
Description: The libzhuyin project aims to provide the algorithms core for intelligent sentence-based Chinese zhuyin input methods.
Fedora Account System Username: pwu

Comment 1 Parag AN(पराग) 2013-12-26 08:52:34 UTC
Review:-

+ Package built successfully in mock (rawhide-x86_64)

+ rpmlint on generated rpms gave
libzhuyin.src: W: spelling-error Summary(en_US) zhuyin -> Zhukov
libzhuyin.src: W: spelling-error %description -l en_US zhuyin -> Zhukov
libzhuyin.x86_64: W: spelling-error Summary(en_US) zhuyin -> Zhukov
libzhuyin.x86_64: W: spelling-error %description -l en_US zhuyin -> Zhukov
libzhuyin-data.x86_64: W: only-non-binary-in-usr-lib
libzhuyin-data.x86_64: W: no-documentation
libzhuyin-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball : aacb7a2a04db2b22380576e27d3118b34f9b6318acbbb6ce25ca962e08a53b59
upstream tarball :  aacb7a2a04db2b22380576e27d3118b34f9b6318acbbb6ce25ca962e08a53b59

+ License is valid and included as headers in source files as well as COPYING.

Suggestions:
1) To have verbose compilation log use
make V=1 %{?_smp_mflags}

2) preserve timestamps of header files using
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"


APPROVED

Comment 2 Peng Wu 2013-12-26 09:04:37 UTC
New Package SCM Request
=======================
Package Name: libzhuyin
Short Description: Library to deal with zhuyin
Owners: pwu
Branches: f20 f19
InitialCC: i18n-team petersen

Comment 3 Jens Petersen 2013-12-27 03:37:55 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-12-27 05:42:00 UTC
libzhuyin-0.9.93-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libzhuyin-0.9.93-1.fc20

Comment 5 Fedora Update System 2013-12-27 05:42:10 UTC
libzhuyin-0.9.93-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libzhuyin-0.9.93-1.fc19

Comment 6 Fedora Update System 2013-12-28 02:14:27 UTC
libzhuyin-0.9.93-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 7 Fedora Update System 2013-12-28 02:15:05 UTC
libzhuyin-0.9.93-1.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.