Bug 1046688 - Review Request: netsurf-buildsystem - makefiles shared by NetSurf projects
Summary: Review Request: netsurf-buildsystem - makefiles shared by NetSurf projects
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1046690 1046691 1046692 1046693
TreeView+ depends on / blocked
 
Reported: 2013-12-26 15:19 UTC by David Tardon
Modified: 2014-08-24 02:56 UTC (History)
3 users (show)

Fixed In Version: netsurf-buildsystem-1.1-2.fc20
Clone Of:
Environment:
Last Closed: 2014-01-02 13:09:00 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Tardon 2013-12-26 15:19:07 UTC
Spec URL: http://dtardon.fedorapeople.org/rpm/netsurf-buildsystem.spec
SRPM URL: http://dtardon.fedorapeople.org/rpm/netsurf-buildsystem-1.0-1.fc20.src.rpm
Description:
netsurf-buildsystem contains makefiles shared by NetSurf projects.

Fedora Account System Username: dtardon

Comment 1 Christopher Meng 2013-12-27 03:38:20 UTC
Only 2 small issues:

1. %build
You should add a note there for the sake of tell others that nothing need to be built.

2. %install
make install DESTDIR=%{buildroot} PREFIX=/usr

You should use %{_prefix} instead of simple straightforward "/usr"

--------------------------

PACKAGE APPROVED.

Comment 2 David Tardon 2013-12-27 07:38:33 UTC
(In reply to Christopher Meng from comment #1)
> Only 2 small issues:
> 
> 1. %build
> You should add a note there for the sake of tell others that nothing need to
> be built.

Does an empty %build section not indicate that quite well already? :-)

> 
> 2. %install
> make install DESTDIR=%{buildroot} PREFIX=/usr
> 
> You should use %{_prefix} instead of simple straightforward "/usr"

I know... I forgot to change it in this one.

Comment 3 David Tardon 2013-12-27 07:42:23 UTC
New Package SCM Request
=======================
Package Name: netsurf-buildsystem
Short Description: Makefiles shared by NetSurf projects
Owners: dtardon caolanm
Branches: 
InitialCC:

Comment 4 Christopher Meng 2013-12-27 08:35:21 UTC
Well, you'd better do that, not you MUST do that. I can't force anyone to do what he or she is reluctant to do, albeit harmless. 

Once I see this package in rawhide repo, I will complete other package reviews.

Comment 5 Gwyn Ciesla 2014-01-02 12:46:43 UTC
Git done (by process-git-requests).

Comment 6 Christopher Meng 2014-01-03 12:38:10 UTC
David, will netsurf* be available for f20?

Comment 7 David Tardon 2014-01-03 20:55:12 UTC
(In reply to Christopher Meng from comment #6)
> David, will netsurf* be available for f20?

I do not plan to make any of the packages available for F-20. Note that I am not packaging the whole NetSurf stack--which is 15 libraries and the browser itself--but just libcss and libhubbub + their deps. I started to use them in libe-book recently, when I decided (or rather, was convinced) to add HTML support. But no new release of libe-book will get into F-20 (for a very good reason, but one that has nothing to do with libcss / libhubbub), so I just do not need them there :-)

Comment 8 Christopher Meng 2014-01-04 03:08:52 UTC
(In reply to David Tardon from comment #7)
> (In reply to Christopher Meng from comment #6)
> > David, will netsurf* be available for f20?
> 
> I do not plan to make any of the packages available for F-20. Note that I am
> not packaging the whole NetSurf stack--which is 15 libraries and the browser
> itself--but just libcss and libhubbub + their deps. I started to use them in
> libe-book recently, when I decided (or rather, was convinced) to add HTML
> support. But no new release of libe-book will get into F-20 (for a very good
> reason, but one that has nothing to do with libcss / libhubbub), so I just
> do not need them there :-)

Ok. I thought that you might packaging netsurf browser which was used by me 1 year ago. ;)

Comment 9 Christopher Meng 2014-08-14 04:40:44 UTC
Package Change Request
======================
Package Name: netsurf-buildsystem
New Branches: f20
Owners: dtardon caolanm cicku

Comment 10 Gwyn Ciesla 2014-08-14 11:49:07 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-08-15 02:09:04 UTC
netsurf-buildsystem-1.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/netsurf-buildsystem-1.1-2.fc20

Comment 12 Fedora Update System 2014-08-24 02:56:38 UTC
netsurf-buildsystem-1.1-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.