Bug 1046986 - Move panel item doesn't scroll list to new position
Summary: Move panel item doesn't scroll list to new position
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: xfce4-panel
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-27 22:54 UTC by Raphael Groner
Modified: 2014-01-09 18:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-09 18:16:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
scroll the list automatically to show the new item position (2.20 KB, patch)
2013-12-27 22:54 UTC, Raphael Groner
no flags Details | Diff
scroll panel item list automatically on movement (improved) (2.16 KB, patch)
2013-12-29 10:06 UTC, Raphael Groner
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Xfce 10582 0 None None None Never

Description Raphael Groner 2013-12-27 22:54:01 UTC
Created attachment 842506 [details]
scroll the list automatically to show the new item position

Description of problem:
When the user moves a panel item out of the visible area in the list view of "items" tab in panel preferences dialog, the list won't scroll automatically to show the newly positioned item and so keep it visible.

Version-Release number of selected component (if applicable):
4.10.1

How reproducible:
yes

Steps to Reproduce:
1.
2.
3.

Actual results:
List view doesn't show the new item position.

Expected results:
List view scrolls to the new item position.

Additional info:
Patch is already submitted to upstream.

Comment 1 Kevin Fenzi 2013-12-28 15:59:39 UTC
We can probibly push an update with this... I guess no word from upstream if this is the correct fix yet. ;(

Comment 2 Raphael Groner 2013-12-29 10:06:41 UTC
Created attachment 842991 [details]
scroll panel item list automatically on movement (improved)

Comment 3 Raphael Groner 2013-12-29 10:08:26 UTC
(In reply to Kevin Fenzi from comment #1)

Hi Kevin,
thanks for your interest. The patch is minor cause only relevant for usability. I guess a scratch build would do it in the first step, while waiting for feedback from upstream.

Comment 4 Kevin Fenzi 2014-01-01 18:44:48 UTC
Sure, can do... did you need f19? Or what version(s)?

Comment 5 Raphael Groner 2014-01-01 18:52:02 UTC
(In reply to Kevin Fenzi from comment #4)
> Sure, can do... did you need f19? Or what version(s)?

fc19 and fc20, both would be nice. Thanks in advance!

Comment 7 Kevin Fenzi 2014-01-01 20:35:59 UTC
Oops. Those didn't have the patch applied. 

Try these: 

f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6346540
f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6346544

Comment 8 Raphael Groner 2014-01-01 20:51:45 UTC
(In reply to Kevin Fenzi from comment #7)

Cool. It works for fc19.

Comment 9 Raphael Groner 2014-01-08 20:40:11 UTC
Upstream has accepted my patch:

http://git.xfce.org/xfce/xfce4-panel/commit/?id=5551513dbb18c73809cc945c1d1649f041d29511

Comment 10 Kevin Fenzi 2014-01-08 22:30:27 UTC
Great. Do you feel this is important enough for us to push a patch now? Or just wait for next upstream release?

Comment 11 Raphael Groner 2014-01-09 18:16:32 UTC
I don't consider it to be that urgent. Maybe we can wait until we have a few more patches. I leave the decision up to you, though this patch isn't about any security or stability issue. I'll close as UPSTREAM.


Note You need to log in before you can comment on or make changes to this bug.