Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-gemnasium-parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-gemnasium-parser-0.1.9-2.fc21.src.rpm Description: Safely parse Gemfiles and gemspecs Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6337793
I wanted to package it too, so I'll review this :)
All good apart from the macros in changelog. You might want to escape them with %%. The test suite is going through an update, but it's been almost a year since then, so I took the liberty and left a comment :) You can wait for a response and try to include the tests or package this as is for now and include them later. Either is fine by me. https://github.com/gemnasium/gemnasium-parser/pull/29#issuecomment-32721326 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /home/axil/review/1046992-rubygem-gemnasium- parser/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). [x]: Package contains Requires: ruby(release). ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Gem should use %gem_install macro. [x]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %{gem_spec}, %exclude %{gem_cache} [x]: Gem package should exclude cached Gem. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-gemnasium-parser-0.1.9-2.fc21.noarch.rpm rubygem-gemnasium-parser-doc-0.1.9-2.fc21.noarch.rpm rubygem-gemnasium-parser-0.1.9-2.fc21.src.rpm rubygem-gemnasium-parser.noarch: W: spelling-error Summary(en_US) gemspecs -> gem specs, gem-specs, gems pecs rubygem-gemnasium-parser.noarch: W: spelling-error %description -l en_US gemspecs -> gem specs, gem-specs, gems pecs rubygem-gemnasium-parser.src: W: spelling-error Summary(en_US) gemspecs -> gem specs, gem-specs, gems pecs rubygem-gemnasium-parser.src: W: spelling-error %description -l en_US gemspecs -> gem specs, gem-specs, gems pecs rubygem-gemnasium-parser.src:86: W: macro-in-%changelog %files rubygem-gemnasium-parser.src:87: W: macro-in-%changelog %prep 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-gemnasium-parser rubygem-gemnasium-parser-do c rubygem-gemnasium-parser.noarch: W: spelling-error Summary(en_US) gemspecs -> gem specs, gem-specs, gems pecs rubygem-gemnasium-parser.noarch: W: spelling-error %description -l en_US gemspecs -> gem specs, gem-specs, gems pecs 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- rubygem-gemnasium-parser (rpmlib, GLIBC filtered): ruby(release) ruby(rubygems) rubygem(bundler) rubygem-gemnasium-parser-doc (rpmlib, GLIBC filtered): rubygem-gemnasium-parser Provides -------- rubygem-gemnasium-parser: rubygem(gemnasium-parser) rubygem-gemnasium-parser rubygem-gemnasium-parser-doc: rubygem-gemnasium-parser-doc Source checksums ---------------- https://rubygems.org/gems/gemnasium-parser-0.1.9.gem : CHECKSUM(SHA256) this package : 95aac29c01d3ea0180cf503a0d59f39fa5c899015454a638dd5c5fd075690d13 CHECKSUM(SHA256) upstream package : 95aac29c01d3ea0180cf503a0d59f39fa5c899015454a638dd5c5fd075690d13 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1046992 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks very much for the review! (And apologies for the delayed response.) You're right about the macros in the changelog. I've fixed them: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-gemnasium-parser.git/commit/?id=5b2d0c2398796d9091ea998dab87abcc01d8346e Regarding the tests, I modified the package so that they'll still run, but will not block the build. This will give greater visibility on failures: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-gemnasium-parser.git/commit/?id=4d6d6a47f182e371ec64edf4895d7f450c58e64d I guess that's the best we can do for now. Thanks again. New Package SCM Request ======================= Package Name: rubygem-gemnasium-parser Short Description: Safely parse Gemfiles and gemspecs Owners: ktdreyer Branches: f20
Git done (by process-git-requests).
Built for Rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=496317 Closing. Thanks again.