Bug 1047084 - Missing Requires for findutils
Summary: Missing Requires for findutils
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libtool
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Raiskup
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-28 22:55 UTC by Kristian Høgsberg
Modified: 2014-02-10 03:14 UTC (History)
5 users (show)

Fixed In Version: libtool-2.4.2-23.fc19
Clone Of:
Environment:
Last Closed: 2014-01-10 07:57:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kristian Høgsberg 2013-12-28 22:55:42 UTC
libtools uses find from findutils but the RPM doesn't have it as a Requires:

[krh@tokamak uturn]$ rpm -qv libtool
libtool-2.4.2-18.fc20.x86_64
[krh@tokamak uturn]$ rpm -q --requires libtool | grep find
[krh@tokamak uturn]$ grep 'find $my_xdir' /usr/bin/libtool
      my_oldobjs="$my_oldobjs "`find $my_xdir -name \*.$objext -print -o -name \*.lo -print | sort | $NL2SP`

Comment 1 Pavel Raiskup 2013-12-30 10:56:58 UTC
Kristian, I can not imagine Linux box unable to run 'find' command; you have
one?  I don't see big need to add findutils (or coreutils, or grep) to Requires.
Do we have some general packaging advice how to deal with that issue?

Actually, you may use alternatively busybox to run find (or other basic
commands).  So hard-wiring libtool with findutils can be bad from principal
POV.

Comment 2 Ondrej Vasik 2013-12-30 12:50:30 UTC
Fedora packaging guidelines talk about "automated" build requires, but runtime Requires should be defined in the package. Usually, if there is no circle dependency, it should not cause any issue, as you said, findutils or busybox are available on vast majority of linux installations. Other possibility would be to adjust the script to fail and inform user about missing find - if the find is required. This is imho acceptable way to deal with "optional" dependency, which just reduces the functionality, but is not a must.

Comment 3 Kristian Høgsberg 2013-12-30 23:00:16 UTC
I'm using yum to create a minimal install root for build testing wayland and weston:

  yum -y --releasever=20 --nogpg --installroot=$path \
    --disablerepo='*'  --enablerepo=fedora install $rpms

where $rpms includes a few basic rpms (systemd, fedora-release) and all the build requirements for wayland and weston.  The list includes libtool but not findutils, and as a result the builds fail spuriously.

Comment 4 Fedora Update System 2014-01-07 09:53:40 UTC
libtool-2.4.2-22.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libtool-2.4.2-22.fc20

Comment 5 Fedora Update System 2014-01-08 07:50:14 UTC
Package libtool-2.4.2-22.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libtool-2.4.2-22.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0381/libtool-2.4.2-22.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-01-10 07:57:19 UTC
libtool-2.4.2-22.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2014-01-23 15:35:06 UTC
libtool-2.4.2-23.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libtool-2.4.2-23.fc19

Comment 8 Fedora Update System 2014-02-10 03:14:30 UTC
libtool-2.4.2-23.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.