Bug 1047119
| Summary: | FavIcon in BPMS and BRMS inconsistent | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] JBoss BPMS Platform 6 | Reporter: | Ryan Zhang <rzhang> | ||||||||
| Component: | Business Central | Assignee: | David Gutierrez <dgutierr> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Tomas Livora <tlivora> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 6.0.0 | CC: | etirelli, jlocker, mbaluch, pzapataf, rrajasek | ||||||||
| Target Milestone: | ER1 | ||||||||||
| Target Release: | 6.0.1 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-08-06 20:03:51 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ryan Zhang
2013-12-29 09:21:54 UTC
Created attachment 842963 [details]
1
Created attachment 842964 [details]
2
Created attachment 842965 [details]
3
*** Bug 1034896 has been marked as a duplicate of this bug. *** This issue was already fixed some days ago in the product branding branch: https://github.com/jboss-integration/kie-wb-distributions/commit/102aca7602975107af0263d823716268d0174da4 I've also looked over the ER7 release artifacts and the favicons are correct. http://dev138.mw.lab.eng.bos.redhat.com/candidate/bpms-6.0.0-ER7/jboss-bpms-6.0.0-redhat-7-deployable-eap6.x.zip So everything seems to be ok. I have cleared my browser cache and also tried both in Chrome and Firefox again. But the issue still remained to me as the bugzilla reports. I also saw the commit in the tag, the favicon.ico in business-central/ folder seems correct.but I don't know why the issue still happen to me the same. If this only happens to me then it 's fine. I will pass it to QE for verification (In reply to David Gutierrez from comment #6) > This issue was already fixed some days ago in the product branding branch: > > https://github.com/jboss-integration/kie-wb-distributions/commit/ > 102aca7602975107af0263d823716268d0174da4 > > > I've also looked over the ER7 release artifacts and the favicons are correct. > > http://dev138.mw.lab.eng.bos.redhat.com/candidate/bpms-6.0.0-ER7/jboss-bpms- > 6.0.0-redhat-7-deployable-eap6.x.zip > > > So everything seems to be ok. I tried with ER7 and couldn't see the favicon in either webapp (dashbuilder or business-central). I guess there might be some issues:
- Security defaults no allowing to see favicon (protected content). A security constrain in web.xml is probably needed.
- The default icon is picked from the root path (/) which is served by EAP. To force the icon, a HTML metadata is probably needed at all pages (login.jsp, regular pages, ...).
For example, for dashbuilder I added the following configuration:
- login.jsp : Add HTMl to header
<link rel="shortcut icon" href="<%=request.getContextPath()%>/favicon.ico" />
- web.xml:
<security-constraint>
<web-resource-collection>
<web-resource-name>Favicon</web-resource-name>
<url-pattern>/favicon.ico</url-pattern>
</web-resource-collection>
</security-constraint>
As @pedro suggested the solution is to grant free access to the favicon.ico and set the login page favicon location as well. Github commits in product branding branch: https://github.com/jboss-integration/dashboard-builder/commit/3cdf23af9c0783abd6ac0aea1513719425148a0d https://github.com/jboss-integration/jbpm-dashboard/commit/1f3bd7bef481eceb1a15f174c57a748494a5110f https://github.com/jboss-integration/kie-wb-distributions/commit/5403a49a23880186f4485f2afaba6872c81d9e52 This fix should be available in the next product build. i.e: CR1 / GA1? The login page and Dashboard Builder use Red Hat's logo as a favicon. But all other pages of Business Central still use the Drools logo. This is how the source code of the login page looks like: <link rel="shortcut icon" href="/business-central/favicon.ico" /> And this is the source code of Business Central's home page: <link rel="shortcut icon" href="images/drools.gif" type="image/gif"/> <link rel="icon" href="images/drools.gif" type="image/gif"/> An extra commit was needed to make the RH's favicon always visible in business-central. https://github.com/jboss-integration/kie-wb-distributions/commit/73699a6fa9c8aeb9e8f3cd0dacbcebc92e833d06 This no longer has a target release of 6.0.0. Verified on BPMS 6.0.1 ER1 |