Description of problem: In the current spec file, you do "rm %{buildroot}%{_bindir}/jsoncheck", but the included jsoncheck is actually useful. The output of `shellcheck` is not machine-readable. `jsoncheck` allows for tooling integration (e.g. it is easy to add shellcheck to Emacs or Vim if jsoncheck exists). Version-Release number of selected component (if applicable): 0.2.0-3 How reproducible: Always Actual results: There is no `jsoncheck` binary installed. Expected results: Have /usr/bin/jsoncheck exist, when the package is installed. Additional info:
As an example of tooling integration that requires jsoncheck: https://github.com/scrooloose/syntastic/commit/2106176#diff-e4c81f050f0024b4758939941f6f57e2R12
Hi, I'm sorry I've broken the syntastic integration (trust me I love syntastic) but I have removed jsoncheck for a couple reasons: 1) it doesn't exist in the current master branch It means that I could only upgrade shellcheck with a new fedora release, because the removal of jsoncheck would be a breaking change. With the next version you'll simply do: shellckeck -f json some_script And it will come with a man page :) 2) jsoncheck is misleading to me It sounds more like a tool that would check some json, and it doesn't feel legitimate in a "shell checking" package to me. I see several solutions, assuming the next shellcheck will hopefully come before f21: - press upstream to get a release soon (there are other features I also want) - backport the "-f json" behavior - restore jsoncheck, and postpone the next update to f21 - restore jsoncheck, and maintain a substitute script with the next updates (and remove it in f21) In any case, I'd need some coordination with the syntastic maintainer. What do you think ?
Ah ha, I wasn't aware that they got merged into one tool. Ok, that's fine. :) I vote for solution #1, let's see if we can bug upstream to release a new version ( And maybe push to Hackage, too. There's a bug upstream about that, but no response yet. :( ). Does that sound reasonable?
Sounds good to me :) I'll go check for a roadmap of some sort first, and then ask upstream what's holding them from releasing a new milestone.
There's a new build for rawhide, ShellCheck-0.3.1: http://koji.fedoraproject.org/koji/taskinfo?taskID=6492554 Before pushing it to f19+, I just want to make sure it also solves bug 1052117.
ShellCheck-0.3.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ShellCheck-0.3.1-3.fc19
ShellCheck-0.3.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ShellCheck-0.3.1-3.fc20
Package ShellCheck-0.3.1-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ShellCheck-0.3.1-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-2258/ShellCheck-0.3.1-3.fc20 then log in and leave karma (feedback).
ShellCheck-0.3.1-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
ShellCheck-0.3.1-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.