Bug 1047416 - Feature request (CLI): Add options to the CLI that let the user control the reset of stats
Summary: Feature request (CLI): Add options to the CLI that let the user control the r...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaushal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-31 03:51 UTC by Dawit Alemu
Modified: 2016-05-06 01:55 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:26:18 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Dawit Alemu 2013-12-31 03:51:38 UTC
Description of problem:
Currently interval stats are cleared upon "volume profile info" automatically and there isn't a command to clear cumulative stats. This ticket is a follow up to Anand's comment in http://review.gluster.org/#/c/6264/.

i.e.
"... implement 'volume profile peek' and 'volume profile clear' commands - where peek will not wipe the interval stats and clear will wipe both interval and cumulative stats"

Version-Release number of selected component (if applicable):


How reproducible:
Feature does not exist.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Dawit Alemu 2013-12-31 03:52:59 UTC
I am working on a patch for this.

Comment 2 Anand Avati 2013-12-31 04:33:39 UTC
REVIEW: http://review.gluster.org/6620 (cli: Add options to the CLI that let the user control the reset of stats) posted (#1) for review on master by Dawit Alemu (dalemu)

Comment 3 Anand Avati 2013-12-31 15:58:46 UTC
REVIEW: http://review.gluster.org/6620 (cli: Add options to the CLI that let the user control the reset of stats) posted (#2) for review on master by Dawit Alemu (dalemu)

Comment 4 Anand Avati 2014-01-16 03:38:37 UTC
REVIEW: http://review.gluster.org/6620 (cli: Add options to the CLI that let the user control the reset of stats) posted (#3) for review on master by Dawit Alemu (dalemu)

Comment 5 Anand Avati 2014-01-24 10:05:44 UTC
COMMIT: http://review.gluster.org/6620 committed in master by Vijay Bellur (vbellur) 
------
commit 48b8186bdc2f5e45b58aadf849b2bd60c9a77330
Author: Dawit Alemu <dalemu>
Date:   Mon Dec 30 22:59:39 2013 -0500

    cli: Add options to the CLI that let the user control the reset of
    stats
    
    "volume profile info" automatically clears incremental stats. There
    isn't a command to:
    - fetch stats without clearing incremental stats and
    - clear cumulative and incremental stats
    
    This change introduces two arguments (i.e. peek and clear). 'clear'
    will wipe both incremental and cumulative stats. 'peek' fetches stats
    without wiping incremental stats.
    
    'volume profile info peek' - fetches incremental and cumulative stats
                                 without wiping incremental stats
    
    'volume profile info incremental peek' - fetches incremental stats
                                         without wiping incremental stats
    
    'volume profile info clear' - clears both incremental and cumultiave
                                  stats
    
    Change-Id: I91834515ad672eca5f882809941147d7d997c4c9
    BUG: 1047416
    Signed-off-by: Dawit Alemu <dalemu>
    Reviewed-on: http://review.gluster.org/6620
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Niels de Vos 2014-09-22 12:34:19 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:26:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.