Spec URL: http://petersen.fedorapeople.org/reviews/ghc-webkit.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-webkit-0.12.5.1-1.fc20.src.rpm Description: WebKit is a web content engine, derived from KHTML and KJS from KDE, and used primarily in Apple's Safari browser. It is made to be embedded in other applications, such as mail readers, or web browsers. It is able to display content such as HTML, SVG, XML, and others. It also supports DOM, XMLHttpRequest, XSLT, CSS, Javascript/ECMAscript and more.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6344172
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11591680 bytes in 496 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "LGPL (v2 or later)", "Unknown or generated". 139 files have unknown license. Detailed output of licensecheck: LGPL (v2 or later) ------------------ webkit-0.12.5.1/hswebkit.h LGPL (v2.1 or later) -------------------- webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/CacheModel.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/hsevents.c webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Download.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/GeolocationPolicyDecision.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/HitTestResult.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Internal.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/NetworkRequest.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/NetworkResponse.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/SecurityOrigin.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/SoupAuthDialog.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebBackForwardList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebDataSource.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebDatabase.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebFrame.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebHistoryItem.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebInspector.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebNavigationAction.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebPolicyDecision.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebResource.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebSettings.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebView.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebWindowFeatures.chs webkit-0.12.5.1/cbits/hsgclosure.h Unknown or generated -------------------- webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Attr.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/BarProp.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Blob.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSRule.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSRuleList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSStyleDeclaration.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSStyleSheet.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSValue.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CharacterData.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Console.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Css.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMApplicationCache.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMImplementation.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMMimeType.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMMimeTypeArray.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMNamedFlowCollection.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMPlugin.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMPluginArray.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSecurityPolicy.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSelection.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSettableTokenList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMStringList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMTokenList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMWindow.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMWindowCSS.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Document.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DocumentType.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Element.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Event.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/EventM.hs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/EventTargetClosures.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Events.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/File.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/FileList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Geolocation.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLAnchorElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLAppletElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLAreaElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLBRElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLBaseElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLBaseFontElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLBodyElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLButtonElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLCanvasElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLCollection.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLDListElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLDetailsElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLDirectoryElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLDivElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLDocument.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLEmbedElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLFieldSetElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLFontElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLFormElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLFrameElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLFrameSetElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLHRElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLHeadElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLHeadingElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLHtmlElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLIFrameElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLImageElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLInputElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLKeygenElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLLIElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLLabelElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLLegendElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLLinkElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLMapElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLMarqueeElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLMediaElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLMenuElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLMetaElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLModElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLOListElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLObjectElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLOptGroupElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLOptionElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLOptionsCollection.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLParagraphElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLParamElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLPreElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLQuoteElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLScriptElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLSelectElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLStyleElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableCaptionElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableCellElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableColElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableRowElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTableSectionElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTextAreaElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLTitleElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLUListElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLVideoElement.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/History.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/KeyboardEvent.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Location.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/MediaError.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/MediaList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/MediaQueryList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/MouseEvent.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/NamedNodeMap.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Navigator.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Node.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/NodeFilter.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/NodeIterator.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/NodeList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/ProcessingInstruction.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Range.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Ranges.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Screen.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Storage.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/StorageInfo.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/StyleMedia.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/StyleSheet.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/StyleSheetList.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Stylesheets.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Text.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/TimeRanges.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Traversal.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/TreeWalker.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/UIEvent.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/ValidityState.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/WebKitNamedFlow.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/WebKitPoint.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/XPathExpression.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/XPathNSResolver.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/XPathResult.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Signals.chs webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Types.chs webkit-0.12.5.1/Gtk2HsSetup.hs webkit-0.12.5.1/Setup.hs webkit-0.12.5.1/SetupMain.hs webkit-0.12.5.1/SetupWrapper.hs webkit-0.12.5.1/cbits/events.h webkit-0.12.5.1/demo/Webkit.hs [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Haskell: [x]: This should never happen ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 12052480 bytes in /usr/share ghc- webkit-devel-0.12.5.1-1.fc21.i686.rpm:12011520 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: ghc-webkit-0.12.5.1-1.fc21.i686.rpm ghc-webkit-devel-0.12.5.1-1.fc21.i686.rpm ghc-webkit-0.12.5.1-1.fc21.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-webkit-devel ghc-webkit 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- ghc-webkit-devel (rpmlib, GLIBC filtered): /bin/sh ghc(webkit-0.12.5.1-162ec8aec01d7b97c7d7027371a4c2aa) ghc-compiler ghc-devel(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) ghc-devel(cairo-0.12.5.0-0c1ae6c7460fccdc6b5f1a8a336b8590) ghc-devel(glib-0.12.5.0-3c9af8a43c22840de5f2b06febf96ede) ghc-devel(gtk-0.12.5.0-934200788293cabaa7c737601f51257f) ghc-devel(mtl-2.1.2-fe866e917274e9b307cc6413975cc313) ghc-devel(pango-0.12.5.0-b36d9bea38e8f04364c38c7bfd8bdff7) ghc-webkit(x86-32) pkgconfig(webkit-1.0) ghc-webkit (rpmlib, GLIBC filtered): ghc(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) ghc(cairo-0.12.5.0-0c1ae6c7460fccdc6b5f1a8a336b8590) ghc(glib-0.12.5.0-3c9af8a43c22840de5f2b06febf96ede) ghc(gtk-0.12.5.0-934200788293cabaa7c737601f51257f) ghc(mtl-2.1.2-fe866e917274e9b307cc6413975cc313) ghc(pango-0.12.5.0-b36d9bea38e8f04364c38c7bfd8bdff7) libHSarray-0.4.0.1-ghc7.6.3.so libHSbase-4.6.0.1-ghc7.6.3.so libHSbytestring-0.10.0.2-ghc7.6.3.so libHScairo-0.12.5.0-ghc7.6.3.so libHScontainers-0.5.0.0-ghc7.6.3.so libHSdeepseq-1.3.0.1-ghc7.6.3.so libHSdirectory-1.2.0.1-ghc7.6.3.so libHSfilepath-1.3.0.1-ghc7.6.3.so libHSghc-prim-0.3.0.0-ghc7.6.3.so libHSgio-0.12.5.0-ghc7.6.3.so libHSglib-0.12.5.0-ghc7.6.3.so libHSgtk-0.12.5.0-ghc7.6.3.so libHSinteger-gmp-0.5.0.0-ghc7.6.3.so libHSmtl-2.1.2-ghc7.6.3.so libHSold-locale-1.0.0.5-ghc7.6.3.so libHSpango-0.12.5.0-ghc7.6.3.so libHSpretty-1.1.1.0-ghc7.6.3.so libHSprocess-1.1.0.2-ghc7.6.3.so libHStime-1.4.0.1-ghc7.6.3.so libHStransformers-0.3.0.0-ghc7.6.3.so libHSunix-2.6.0.1-ghc7.6.3.so libHSutf8-string-0.3.7-ghc7.6.3.so libatk-1.0.so.0 libc.so.6 libcairo.so.2 libdl.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmp.so.10 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libjavascriptcoregtk-1.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0 librt.so.1 libsoup-2.4.so.1 libutil.so.1 libwebkitgtk-1.0.so.0 libz.so.1 rtld(GNU_HASH) Provides -------- ghc-webkit-devel: ghc-devel(webkit-0.12.5.1-162ec8aec01d7b97c7d7027371a4c2aa) ghc-webkit-devel ghc-webkit-devel(x86-32) ghc-webkit-static ghc-webkit: ghc(webkit-0.12.5.1-162ec8aec01d7b97c7d7027371a4c2aa) ghc-webkit ghc-webkit(x86-32) libHSwebkit-0.12.5.1-ghc7.6.3.so Unversioned so-files -------------------- ghc-webkit: /usr/lib/ghc-7.6.3/webkit-0.12.5.1/libHSwebkit-0.12.5.1-ghc7.6.3.so Source checksums ---------------- http://hackage.haskell.org/packages/archive/webkit/0.12.5.1/webkit-0.12.5.1.tar.gz : CHECKSUM(SHA256) this package : 7cfe047175ec7af8479af706cdbb82b53282483ee6ee24b90d5ea568153a1d33 CHECKSUM(SHA256) upstream package : 7cfe047175ec7af8479af706cdbb82b53282483ee6ee24b90d5ea568153a1d33 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn ghc-webkit-0.12.5.1-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG -------------------- PACKAGE APPROVED. One question before "+", I think the doc is very large, is it better to add -doc subpackage? I'm not sure if we should do this for haskell package, please tell me. Thanks!
Thanks Christopher for reviewing the package so soon. (In reply to Christopher Meng from comment #2) > One question before "+", I think the doc is very large, is it better to add > -doc subpackage? I'm not sure if we should do this for haskell package, > please tell me. Good question. $ du -sh /usr/share/doc/ghc/html/libraries/webkit/ /usr/lib64/ghc-7.6.3/webkit-0.12.5.1/ 12M /usr/share/doc/ghc/html/libraries/webkit/ 49M /usr/lib64/ghc-7.6.3/webkit-0.12.5.1/ I admit the size of the docs here is not negligible. To be honest it is partly a packaging convenience/simplification, since the package docs can cross-reference docs of dependencies they need to be BRs, so subpackaging docs effectively doubles the number of BRs in each package, which also increases the time for downloading and installing. The previous version of the Haskell Guidelines (2011) actually recommend having a doc subpackage, but I felt they were generally an overhead, so this was dropped in the revised Guidelines. Generally the installed size of generated devel docs is still small compared to the total of the devel files, and they compress well. Perhaps we need a more precise criterion for deciding when docs are too big to be bundled in the devel package: from the packaging maintenance PoV it would be simpler to make it all or none though, but perhaps cabal-rpm could work out which library packages have a doc subpackage or not. At least since we don't rebuild the doc index after each devel package install, the install/uninstall overhead of docs is not heavy anymore.
Thanks again! I also plan to package up the webkitgtk3 binding once ghc-gtk3 (bug 1045963) has been reviewed. New Package SCM Request ======================= Package Name: ghc-webkit Short Description: Binding to the Webkit library for gtk2 Owners: petersen Branches: f20 f19 el6 InitialCC: haskell-sig
Git done (by process-git-requests).
Built for f21 rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=487644 I will build for f20 in a few days after the https://admin.fedoraproject.org/updates/FEDORA-2013-24050/ghc-gtk-0.12.5.0-1.fc20 stack is pushed stable
ghc-webkit-0.12.5.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-webkit-0.12.5.1-1.fc20
ghc-webkit-0.12.5.1-1.fc20 has been pushed to the Fedora 20 testing repository.
ghc-webkit-0.12.5.1-1.fc20 has been pushed to the Fedora 20 stable repository.