Bug 1047514 - libvirtd does not stop when using vdsm-tool configure --force
Summary: libvirtd does not stop when using vdsm-tool configure --force
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.4.0
Assignee: Yaniv Bronhaim
QA Contact:
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-31 13:26 UTC by Yaniv Bronhaim
Modified: 2016-02-10 19:20 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-14 14:04:54 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Yaniv Bronhaim 2013-12-31 13:26:26 UTC
Description of problem:

the tool uses "vdsm-tool service-status" to check for libvirtd status, this runs service libvirtd status instead of using upstat over RHEL. It reports the libvirtd is stopped while it doesn't . the configure proceed but without restarting the service or alert the it runs


How reproducible:
100%

Steps to Reproduce:
run libvirtd, stop vdsmd and supervdsmd
run vdsm-tool configure (without --force)
we configure libvirtd.conf without managing the service

Actual results:
libvirt is running with old configuration, althought the configure ran and modified the configuration file underneath the service. 

Expected results:
vdsm-tool configure should not start and alert that libvirtd is running.


Additional info:

Comment 1 Yaniv Bronhaim 2014-01-14 08:31:26 UTC
my mistake. vdsm-tool service verbs try to use initctl before sysV methods. although if admin ran - "service libvirtd start" and then run vdsm-tool configure, we have mixed up operations -> libvirtd will be up, but vdsm-tool service-status will report that libvirtd is down and won't restart it even with --force flag.

Is that a bug ? I'm not sure.. it was always like that, but we never let admin to start and stop libvirtd before, we did it automatically, and now we have this risk that can cause some async situations

Comment 2 Alon Bar-Lev 2014-01-14 09:14:32 UTC
anything you do should be consistent. or I miss something.

Comment 3 Zhou Zheng Sheng 2014-01-14 09:29:12 UTC
It's a RHEL6 problem that it does not provide a way to redirect SysV "service" commands to Upstart. In recent Ubuntu releases you can just create a soft link "/etc/init.d/libvirtd -> /lib/init/upstart-job", and all "service libvirtd XXX" are redirected to Upstart. The Upstart version in RHEL6 is too old, and its SysV compatibility feature is too weak.

Comment 4 Yaniv Bronhaim 2014-01-14 14:04:54 UTC
OK, afaiu we (ovirt) don't handle such cases, and the service tool does work as expected if libvirtd is started by initctl as required with vdsm.

I'll add better comments during handling bz 1029812 which will tell the admin to use initctl when managing libvirtd manually 


Closing the bug


Note You need to log in before you can comment on or make changes to this bug.