Spec URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg.spec SRPM URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg-0.3.5-2.fc20.src.rpm Description: Python module for GnuPG Fedora Account System Username: pwouters
Spec URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg.spec SRPM URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg-0.3.5-3.fc20.src.rpm Sat Jan 04 2014 Paul Wouters <pwouters> - 0.3.5-3 - Remove unused global, fix python macro, buildroot macro - Converted README from DOS to unix (and reported upstream)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== ISSUES ==== - License in file is "Python" while this code is under the BSD license (Also, please ask upstream to add that in the header for every file) - Please remove the "rm -rf %{buildroot}" from %install - Should require gpg - Please explain why the patch is needed and if you sent it upstream ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-gnupg-0.3.5-3.fc21.noarch.rpm python-gnupg-0.3.5-3.fc20.src.rpm python-gnupg.noarch: W: spelling-error %description -l en_US fixme -> fix me, fix-me, fixer python-gnupg.src: W: spelling-error %description -l en_US fixme -> fix me, fix-me, fixer 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-gnupg python-gnupg.noarch: W: spelling-error %description -l en_US fixme -> fix me, fix-me, fixer 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python-gnupg (rpmlib, GLIBC filtered): python(abi) Provides -------- python-gnupg: python-gnupg Source checksums ---------------- http://python-gnupg.googlecode.com/files/python-gnupg-0.3.5.tar.gz : CHECKSUM(SHA256) this package : 4ce2922a03f07dbd13838a9fe9611b6dabe88966c369f8daa2cd86b896520f43 CHECKSUM(SHA256) upstream package : 4ce2922a03f07dbd13838a9fe9611b6dabe88966c369f8daa2cd86b896520f43 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --prebuilt -n python-gnupg Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG
Spec URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg.spec SRPM URL: ftp://ftp.nohats.ca/python-gnupg/python-gnupg-0.3.5-4.fc20.src.rpm * Mon Jan 06 2014 Paul Wouters <pwouters> - 0.3.5-4 - Require gnupg (duh) - Remove cleaning in install target - Fix license to BSD - Link to upstream bug tracker for included patch
Looks fine to me. APPROVED
New Package SCM Request ======================= Package Name: python-gnupg Short Description: Python module for GnuPG Owners: pwouters Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
python-gnupg-0.3.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-gnupg-0.3.5-4.el6
python-gnupg-0.3.5-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-gnupg-0.3.5-4.fc19
python-gnupg-0.3.5-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-gnupg-0.3.5-4.fc20
python-gnupg-0.3.5-4.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-gnupg-0.3.5-4.fc20 has been pushed to the Fedora 20 stable repository.
python-gnupg-0.3.5-4.fc19 has been pushed to the Fedora 19 stable repository.
python-gnupg-0.3.5-4.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-gnupg New Branches: epel7 Owners: pwouters