Spec URL: https://www.happyassassin.net/reviews/php-google-api-php-client/php-google-api-php-client.spec SRPM URL: https://www.happyassassin.net/reviews/php-google-api-php-client/php-google-api-php-client-0.6.7-1.fc21.src.rpm Description: The Google API client library allows one to work with Google APIs such as Analytics, Adsense, Google+, Calendar, Drive or Games. It includes support for HTTP streams, which makes it simple to use the library from an App Engine application just by tweaking the configuration file. Fedora Account System Username: adamwill
OwnCloud bundles this, it's part of my unbundling work. I've tested that OC works with this system copy of google-api-php-client , after the obvious modifications to find it.
Hi Adam, I would like to attempt an **unofficial** review as a part of learning packaging. So, please excuse me if I say something silly! :) My comments - * spec file Requires: should be moved to before %description. If I build the rpm as it is now, yum is not pulling in the deps. Moving Requires: seems to fix that problem. Running fedora-review produces this - Requires -------- php-google-api-php-client (rpmlib, GLIBC filtered): which does not list the other dependencies. Mukundan (nonamedotc)
"* spec file Requires: should be moved to before %description. If I build the rpm as it is now, yum is not pulling in the deps. Moving Requires: seems to fix that problem." Hah, you're quite right, good catch. "which does not list the other dependencies." I don't use fedora-review myself and am not familiar with exactly what it does, but the PHP experts use php-compat-info, which you can get from the php-pear-PHP-CompatInfo package, to evaluate the likely dependencies of PHP code (it's generally pretty reliable, but it does go wrong sometimes, and it's best to use it as a starting point for manual check of the code).
Cancelling this request. Shawn Iwinski is planning to submit a review request for v1.x of the library: https://raw2.github.com/siwinski/rpms/master/php-google-api.spec and I've ported the OC app to v1.x (see https://github.com/owncloud/core/pull/6989 ), so we don't really need this.