Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1047649

Summary:	[Hosted Engine] Unify maintenance flows
Product:	[Retired] oVirt	Reporter:	Doron Fediuck <dfediuck>
Component:	ovirt-engine-core	Assignee:	Greg Padgett <gpadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.4	CC:	acathrow, amureini, didi, gpadgett, iheim, mavital, mkalinin, msivak, yeylon
Target Milestone:	---
Target Release:	3.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	sla
Fixed In Version:	ovirt-3.4.0-rc	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1053040 1053677 (view as bug list)		Environment:
Last Closed:	2014-03-31 12:26:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1075126
Bug Blocks:

Description Doron Fediuck 2014-01-01 14:22:28 UTC

Description of problem:
Currently hosted engine has its own flows to maintenance the engine VM and another flow to maintenance an HA-enabled host.

These flows should be unified with the existing host maintenance flows.

Comment 1 Doron Fediuck 2014-01-01 14:23:55 UTC

This BZ was created for the engine side, but another may be needed for VDSM to support HA-maintenance request from the engine.

Comment 2 Itamar Heim 2014-01-12 08:42:42 UTC

setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.

Comment 3 Greg Padgett 2014-02-18 17:39:10 UTC

Merged Change-Ids:
Ib62849ffe0f7392c1feb1f2a0536a23410b58210
I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74
I17f0eff120b2ab99b4badc53da1780c1e758299c

Comment 4 Greg Padgett 2014-02-19 14:48:51 UTC

Changes merged upstream master, still pending merge in 3.4 branch (... moving back to post for now)

Comment 5 Sandro Bonazzola 2014-03-03 14:40:12 UTC

This BZ should be fixed in oVirt 3.4.0 RC

Comment 6 Sandro Bonazzola 2014-03-31 12:26:13 UTC

this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released

Comment 7 Marina Kalinin 2016-05-17 18:58:06 UTC

So, if I understand this bug correctly, putting HE host into maintenance should apply local HE maintenance on the host.

However, it is not the case on my 3.6.3 environment.
rhevm-3.6.3.4-0.1.el6
ovirt-hosted-engine-ha-1.3.4.3-1.el7ev

After putting a host in maintenance, running the following on the host:
# hosted-engine --vm-status  # does not report any maintenance:
...
Local maintenance                  : False
...

# systemctl status ovirt-ha-agent.service
# systemctl status ovirt-ha-broker.service 

Both services are running.

Is this a bug or I misunderstand the behavior?

Comment 8 Greg Padgett 2016-05-17 19:49:53 UTC

(In reply to Marina from comment #7)
> So, if I understand this bug correctly, putting HE host into maintenance
> should apply local HE maintenance on the host.
> 
> However, it is not the case on my 3.6.3 environment.
> rhevm-3.6.3.4-0.1.el6
> ovirt-hosted-engine-ha-1.3.4.3-1.el7ev
> 
> After putting a host in maintenance, running the following on the host:
> # hosted-engine --vm-status  # does not report any maintenance:
> ...
> Local maintenance                  : False
> ...
> 
> # systemctl status ovirt-ha-agent.service
> # systemctl status ovirt-ha-broker.service 
> 
> Both services are running.
> 
> Is this a bug or I misunderstand the behavior?

This was the original behavior, but I'm not sure if something may have changed since then.  Martin?

Comment 9 Yedidyah Bar David 2016-05-18 05:50:22 UTC

I am pretty certain that it worked for me when I tried.

Perhaps it just takes time?

Did you try checking status continuously, or at least 1-2 minutes later?

Did you have VMs there? It might be that the status changes only some time after all VMs are migrated away, not sure.

If this does not work no matter what, I'd suggest to open a new bug and attach engine and HA logs.

Comment 10 Martin Sivák 2016-05-18 10:05:39 UTC

Yeah it should still behave like that.

Comment 11 Doron Fediuck 2016-05-18 11:58:22 UTC

Marina,
if you see something different, please open a new BZ and provide all
the information. You can add this bz as a general reference.

Comment 12 Marina Kalinin 2016-05-18 14:43:59 UTC

Ok, last question before I open the bug.
Indeed, after flipping back and forward, final status of the host became correct:
# hosted-engine --vm-status
...
Local maintenance                  : True
...

However, both HA services are still running.
Is this correct?

Comment 13 Martin Sivák 2016-05-31 10:32:58 UTC

Yes, hosted engine services are still up during local maintenance. The services are responsible for telling other nodes about the status.