Spec URL: http://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-cairo-gobject.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-cairo-gobject-2.1.0-1.fc.src.rpm Description: Ruby/CairoGObject is a Ruby binding of cairo-gobject. Fedora Account System Username: mtasaka
I can take this review.
Looks fine, package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-cairo-gobject-2.1.0-1.fc19.i686.rpm rubygem-cairo-gobject-doc-2.1.0-1.fc19.noarch.rpm rubygem-cairo-gobject-2.1.0-1.fc19.src.rpm rubygem-cairo-gobject.i686: W: no-soname /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-cairo-gobject rubygem-cairo-gobject-doc rubygem-cairo-gobject.i686: W: no-soname /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_FontOptions rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_Device rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_Surface rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_ScaledFont rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_FontFace rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_Pattern rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_Region rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cCairo_Context rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_font_options_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rbgobj_define_class rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_device_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rbgobj_convert_define rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rbgobj_make_boxed_default rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rbgobj_boxed_get_default rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_context_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_region_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_scaled_font_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_region_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_surface_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_font_options_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_surface_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_pattern_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_font_face_to_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_pattern_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_device_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_scaled_font_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_context_from_ruby_object rubygem-cairo-gobject.i686: W: undefined-non-weak-symbol /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so rb_cairo_font_face_from_ruby_object rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libcairo.so.2 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libgobject-2.0.so.0 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libglib-2.0.so.0 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libpthread.so.0 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/librt.so.1 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libdl.so.2 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libcrypt.so.1 rubygem-cairo-gobject.i686: W: unused-direct-shlib-dependency /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so /lib/libm.so.6 2 packages and 0 specfiles checked; 0 errors, 37 warnings. # echo 'rpmlint-done:' Requires -------- rubygem-cairo-gobject (rpmlib, GLIBC filtered): libc.so.6 libcairo-gobject.so.2 libcairo.so.2 libcrypt.so.1 libdl.so.2 libglib-2.0.so.0 libgobject-2.0.so.0 libm.so.6 libpthread.so.0 librt.so.1 libruby.so.2.0 rtld(GNU_HASH) ruby ruby(rubygems) rubygem(cairo) rubygem(glib2) rubygem-cairo-gobject-doc (rpmlib, GLIBC filtered): rubygem-cairo-gobject Provides -------- rubygem-cairo-gobject: cairo_gobject.so rubygem(cairo-gobject) rubygem-cairo-gobject rubygem-cairo-gobject(x86-32) rubygem-cairo-gobject-doc: rubygem-cairo-gobject-doc Unversioned so-files -------------------- rubygem-cairo-gobject: /usr/lib/gems/ruby/cairo-gobject-2.1.0/lib/cairo_gobject.so Source checksums ---------------- https://rubygems.org/gems/cairo-gobject-2.1.0.gem : CHECKSUM(SHA256) this package : 8594040f5600548044d85a5e97b7b2d1c9ed0c5c38635b2d6ecc7efa37503180 CHECKSUM(SHA256) upstream package : 8594040f5600548044d85a5e97b7b2d1c9ed0c5c38635b2d6ecc7efa37503180 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047655 -x CheckDirectoryRequire,CheckOwnDirs Buildroot used: fedora-19-i386 Active plugins: Generic, Ruby, Shell-api, C/C++ Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP Disabled flags: EPEL5, EXARCH, DISTTAG
Okay, thank you! New Package SCM Request ======================= Package Name: rubygem-cairo-gobject Short Description: Ruby binding of cairo-gobject Owners: mtasaka Branches: f20
Git done (by process-git-requests).
Built on all branches, push requested for F-20 on bodhi, closing. Thank you for review and git procedure.